From: malc <av1474@comtv.ru>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [6292] Do not rely on __powerpc__ being defined as a feature test macro
Date: Tue, 13 Jan 2009 23:12:35 +0000 [thread overview]
Message-ID: <E1LMsR1-0004nA-5m@cvs.savannah.gnu.org> (raw)
Revision: 6292
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6292
Author: malc
Date: 2009-01-13 23:12:34 +0000 (Tue, 13 Jan 2009)
Log Message:
-----------
Do not rely on __powerpc__ being defined as a feature test macro
__powerpc__ is not defined on AIX and Darwin, Makefile.target adds
it to CPPFLAGS for target specific code which cache-utils are not.
Since there's not common definition which can safely be used on all
platforms use HOST_PPC provided by config-host.h
The problem was originally reported by C. W. Betts
Modified Paths:
--------------
trunk/cache-utils.c
trunk/cache-utils.h
Modified: trunk/cache-utils.c
===================================================================
--- trunk/cache-utils.c 2009-01-13 21:09:18 UTC (rev 6291)
+++ trunk/cache-utils.c 2009-01-13 23:12:34 UTC (rev 6292)
@@ -1,6 +1,6 @@
#include "cache-utils.h"
-#ifdef __powerpc__
+#ifdef HOST_PPC
struct qemu_cache_conf qemu_cache_conf = {
.dcache_bsize = 16,
.icache_bsize = 16
@@ -68,4 +68,4 @@
}
#endif
-#endif /* __powerpc__ */
+#endif /* HOST_PPC */
Modified: trunk/cache-utils.h
===================================================================
--- trunk/cache-utils.h 2009-01-13 21:09:18 UTC (rev 6291)
+++ trunk/cache-utils.h 2009-01-13 23:12:34 UTC (rev 6292)
@@ -1,7 +1,9 @@
#ifndef QEMU_CACHE_UTILS_H
#define QEMU_CACHE_UTILS_H
-#ifdef __powerpc__
+#include "config-host.h"
+
+#ifdef HOST_PPC
struct qemu_cache_conf {
unsigned long dcache_bsize;
unsigned long icache_bsize;
next reply other threads:[~2009-01-13 23:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 23:12 malc [this message]
[not found] ` <40789D00-0F5D-4BA5-91D9-582FE3052E2A@hotmail.com>
2009-01-14 6:22 ` [Qemu-devel] [6292] Do not rely on __powerpc__ being defined as a feature test macro C.W. Betts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1LMsR1-0004nA-5m@cvs.savannah.gnu.org \
--to=av1474@comtv.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).