From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LMsR5-0007B1-Ku for qemu-devel@nongnu.org; Tue, 13 Jan 2009 18:12:39 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LMsR4-0007Ab-11 for qemu-devel@nongnu.org; Tue, 13 Jan 2009 18:12:39 -0500 Received: from [199.232.76.173] (port=55108 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LMsR3-0007AY-Tl for qemu-devel@nongnu.org; Tue, 13 Jan 2009 18:12:37 -0500 Received: from savannah.gnu.org ([199.232.41.3]:46098 helo=sv.gnu.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LMsR2-0008EG-QS for qemu-devel@nongnu.org; Tue, 13 Jan 2009 18:12:37 -0500 Received: from cvs.savannah.gnu.org ([199.232.41.69]) by sv.gnu.org with esmtp (Exim 4.63) (envelope-from ) id 1LMsR1-0004nG-E7 for qemu-devel@nongnu.org; Tue, 13 Jan 2009 23:12:35 +0000 Received: from malc by cvs.savannah.gnu.org with local (Exim 4.63) (envelope-from ) id 1LMsR1-0004nA-5m for qemu-devel@nongnu.org; Tue, 13 Jan 2009 23:12:35 +0000 MIME-Version: 1.0 Errors-To: malc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: malc Message-Id: Date: Tue, 13 Jan 2009 23:12:35 +0000 Subject: [Qemu-devel] [6292] Do not rely on __powerpc__ being defined as a feature test macro Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Revision: 6292 http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6292 Author: malc Date: 2009-01-13 23:12:34 +0000 (Tue, 13 Jan 2009) Log Message: ----------- Do not rely on __powerpc__ being defined as a feature test macro __powerpc__ is not defined on AIX and Darwin, Makefile.target adds it to CPPFLAGS for target specific code which cache-utils are not. Since there's not common definition which can safely be used on all platforms use HOST_PPC provided by config-host.h The problem was originally reported by C. W. Betts Modified Paths: -------------- trunk/cache-utils.c trunk/cache-utils.h Modified: trunk/cache-utils.c =================================================================== --- trunk/cache-utils.c 2009-01-13 21:09:18 UTC (rev 6291) +++ trunk/cache-utils.c 2009-01-13 23:12:34 UTC (rev 6292) @@ -1,6 +1,6 @@ #include "cache-utils.h" -#ifdef __powerpc__ +#ifdef HOST_PPC struct qemu_cache_conf qemu_cache_conf = { .dcache_bsize = 16, .icache_bsize = 16 @@ -68,4 +68,4 @@ } #endif -#endif /* __powerpc__ */ +#endif /* HOST_PPC */ Modified: trunk/cache-utils.h =================================================================== --- trunk/cache-utils.h 2009-01-13 21:09:18 UTC (rev 6291) +++ trunk/cache-utils.h 2009-01-13 23:12:34 UTC (rev 6292) @@ -1,7 +1,9 @@ #ifndef QEMU_CACHE_UTILS_H #define QEMU_CACHE_UTILS_H -#ifdef __powerpc__ +#include "config-host.h" + +#ifdef HOST_PPC struct qemu_cache_conf { unsigned long dcache_bsize; unsigned long icache_bsize;