From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [6323] bdrv_write should not stop on partial write (Gleb Natapov)
Date: Thu, 15 Jan 2009 20:43:39 +0000 [thread overview]
Message-ID: <E1LNZ3z-0004Xz-Ce@cvs.savannah.gnu.org> (raw)
Revision: 6323
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6323
Author: aliguori
Date: 2009-01-15 20:43:39 +0000 (Thu, 15 Jan 2009)
Log Message:
-----------
bdrv_write should not stop on partial write (Gleb Natapov)
Should return real error instead.
Signed-off-by: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Modified Paths:
--------------
trunk/block.c
Modified: trunk/block.c
===================================================================
--- trunk/block.c 2009-01-15 20:37:28 UTC (rev 6322)
+++ trunk/block.c 2009-01-15 20:43:39 UTC (rev 6323)
@@ -565,21 +565,22 @@
if (bs->read_only)
return -EACCES;
if (drv->bdrv_pwrite) {
- int ret, len;
+ int ret, len, count = 0;
len = nb_sectors * 512;
- ret = drv->bdrv_pwrite(bs, sector_num * 512, buf, len);
- if (ret < 0)
- return ret;
- else if (ret != len)
- return -EIO;
- else {
- bs->wr_bytes += (unsigned) len;
- bs->wr_ops ++;
- return 0;
- }
- } else {
- return drv->bdrv_write(bs, sector_num, buf, nb_sectors);
+ do {
+ ret = drv->bdrv_pwrite(bs, sector_num * 512, buf, len - count);
+ if (ret < 0) {
+ printf("bdrv_write ret=%d\n", ret);
+ return ret;
+ }
+ count += ret;
+ buf += ret;
+ } while (count != len);
+ bs->wr_bytes += (unsigned) len;
+ bs->wr_ops ++;
+ return 0;
}
+ return drv->bdrv_write(bs, sector_num, buf, nb_sectors);
}
static int bdrv_pread_em(BlockDriverState *bs, int64_t offset,
reply other threads:[~2009-01-15 20:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1LNZ3z-0004Xz-Ce@cvs.savannah.gnu.org \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).