From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [6330] Fix Windows build (Herv?\195?\169 Poussineau)
Date: Thu, 15 Jan 2009 21:39:42 +0000 [thread overview]
Message-ID: <E1LNZwE-0007s4-0s@cvs.savannah.gnu.org> (raw)
Revision: 6330
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6330
Author: aliguori
Date: 2009-01-15 21:39:41 +0000 (Thu, 15 Jan 2009)
Log Message:
-----------
Fix Windows build (Herv?\195?\169 Poussineau)
r6303 broke Windows build, where "noreturn" is a keyword used with __declspec.
Attached patch fixes Windows build, by moving windows.h header inclusion before Qemu noreturn define.
Signed-off-by: Herv?\195?\169 Poussineau <hpoussin@reactos.org>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Modified Paths:
--------------
trunk/qemu-common.h
Modified: trunk/qemu-common.h
===================================================================
--- trunk/qemu-common.h 2009-01-15 21:24:24 UTC (rev 6329)
+++ trunk/qemu-common.h 2009-01-15 21:39:41 UTC (rev 6330)
@@ -2,6 +2,12 @@
#ifndef QEMU_COMMON_H
#define QEMU_COMMON_H
+#ifdef _WIN32
+#define WIN32_LEAN_AND_MEAN
+#define WINVER 0x0501 /* needed for ipv6 bits */
+#include <windows.h>
+#endif
+
#define noreturn __attribute__ ((__noreturn__))
/* Hack around the mess dyngen-exec.h causes: We need noreturn in files that
@@ -47,9 +53,6 @@
#endif
#ifdef _WIN32
-#define WIN32_LEAN_AND_MEAN
-#define WINVER 0x0501 /* needed for ipv6 bits */
-#include <windows.h>
#define fsync _commit
#define lseek _lseeki64
#define ENOTSUP 4096
reply other threads:[~2009-01-15 21:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1LNZwE-0007s4-0s@cvs.savannah.gnu.org \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).