From: Blue Swirl <blauwirbel@gmail.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [6362] Remove unused info_str parameter to pcnet_common_init()
Date: Sat, 17 Jan 2009 20:47:10 +0000 [thread overview]
Message-ID: <E1LOI4U-0000jv-If@cvs.savannah.gnu.org> (raw)
Revision: 6362
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6362
Author: blueswir1
Date: 2009-01-17 20:47:10 +0000 (Sat, 17 Jan 2009)
Log Message:
-----------
Remove unused info_str parameter to pcnet_common_init()
I noticed that pcnet_common_init() takes an unused 'info_str'
parameter, added in r2142. Since then, we always pass "pcnet"
to register_savevm() (and never "lance").
Note that r6218 changed vc->info_str to "lance" for sun4m emulation.
On the assumption that it's not needed, this patch removes the
parameter. If reverting the change in r2142, and registering with
"lance" would be preferable, I can submit a patch to do so.
Signed-off-by: Stuart Brady <stuart.brady@gmail.com>
Modified Paths:
--------------
trunk/hw/pcnet.c
Modified: trunk/hw/pcnet.c
===================================================================
--- trunk/hw/pcnet.c 2009-01-17 18:41:53 UTC (rev 6361)
+++ trunk/hw/pcnet.c 2009-01-17 20:47:10 UTC (rev 6362)
@@ -1929,7 +1929,7 @@
return 0;
}
-static void pcnet_common_init(PCNetState *d, NICInfo *nd, const char *info_str)
+static void pcnet_common_init(PCNetState *d, NICInfo *nd)
{
d->poll_timer = qemu_new_timer(vm_clock, pcnet_poll_timer, d);
@@ -2032,7 +2032,7 @@
d->phys_mem_write = pci_physical_memory_write;
d->pci_dev = &d->dev;
- pcnet_common_init(d, nd, "pcnet");
+ pcnet_common_init(d, nd);
}
/* SPARC32 interface */
@@ -2106,6 +2106,6 @@
d->phys_mem_read = ledma_memory_read;
d->phys_mem_write = ledma_memory_write;
- pcnet_common_init(d, nd, "lance");
+ pcnet_common_init(d, nd);
}
#endif /* TARGET_SPARC */
reply other threads:[~2009-01-17 20:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1LOI4U-0000jv-If@cvs.savannah.gnu.org \
--to=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).