[Qemu-devel] [6384] cirrus: avoid resetting vga dirty logging unnecessarily (Avi Kivity)

[Qemu-devel] [6384] cirrus: avoid resetting vga dirty logging unnecessarily (Avi Kivity)

[Anthony Liguori]

Revision: 6384
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6384
Author:   aliguori
Date:     2009-01-21 18:31:26 +0000 (Wed, 21 Jan 2009)

Log Message:
-----------
cirrus: avoid resetting vga dirty logging unnecessarily (Avi Kivity)

cirrus bitblt reset will stop and start dirty logging even when there is no
need; this causes full redraws.

avoid by only updating memory access when exiting cpu-to-video update mode.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

Modified Paths:
--------------
    trunk/hw/cirrus_vga.c

Modified: trunk/hw/cirrus_vga.c
===================================================================
--- trunk/hw/cirrus_vga.c	2009-01-21 18:31:16 UTC (rev 6383)
+++ trunk/hw/cirrus_vga.c	2009-01-21 18:31:26 UTC (rev 6384)
@@ -850,11 +850,17 @@
 
 static void cirrus_bitblt_reset(CirrusVGAState * s)
 {
+    int need_update;
+
     s->gr[0x31] &=
 	~(CIRRUS_BLT_START | CIRRUS_BLT_BUSY | CIRRUS_BLT_FIFOUSED);
+    need_update = s->cirrus_srcptr != &s->cirrus_bltbuf[0]
+        || s->cirrus_srcptr_end != &s->cirrus_bltbuf[0];
     s->cirrus_srcptr = &s->cirrus_bltbuf[0];
     s->cirrus_srcptr_end = &s->cirrus_bltbuf[0];
     s->cirrus_srccounter = 0;
+    if (!need_update)
+        return;
     cirrus_update_memory_access(s);
 }