qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [6430] Use broadcast address for slirp dhcp replies
Date: Sat, 24 Jan 2009 18:16:19 +0000	[thread overview]
Message-ID: <E1LQn3L-0008Bo-JZ@cvs.savannah.gnu.org> (raw)

Revision: 6430
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6430
Author:   aurel32
Date:     2009-01-24 18:16:18 +0000 (Sat, 24 Jan 2009)

Log Message:
-----------
Use broadcast address for slirp dhcp replies

Windows Vista drops unicast dhcp replies to its yet-unconfigured address,
so use a broadcast address.  This behaviour is allowed by the RFC.

Signed-off-by: Avi Kivity <avi@redhat.com>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>

Modified Paths:
--------------
    trunk/slirp/bootp.c

Modified: trunk/slirp/bootp.c
===================================================================
--- trunk/slirp/bootp.c	2009-01-24 18:06:21 UTC (rev 6429)
+++ trunk/slirp/bootp.c	2009-01-24 18:16:18 UTC (rev 6430)
@@ -191,6 +191,8 @@
     rbp->bp_yiaddr = daddr.sin_addr; /* Client IP address */
     rbp->bp_siaddr = saddr.sin_addr; /* Server IP address */
 
+    daddr.sin_addr.s_addr = 0xffffffffu;
+
     q = rbp->bp_vend;
     memcpy(q, rfc1533_cookie, 4);
     q += 4;

                 reply	other threads:[~2009-01-24 18:16 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1LQn3L-0008Bo-JZ@cvs.savannah.gnu.org \
    --to=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).