From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LRY88-00029n-Bx
	for qemu-devel@nongnu.org; Mon, 26 Jan 2009 15:32:24 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LRY87-00029D-JH
	for qemu-devel@nongnu.org; Mon, 26 Jan 2009 15:32:23 -0500
Received: from [199.232.76.173] (port=35307 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LRY87-000295-Dy
	for qemu-devel@nongnu.org; Mon, 26 Jan 2009 15:32:23 -0500
Received: from savannah.gnu.org ([199.232.41.3]:60983 helo=sv.gnu.org)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <INVALID.NOREPLY@gnu.org>)
	id 1LRY87-0007nc-3c
	for qemu-devel@nongnu.org; Mon, 26 Jan 2009 15:32:23 -0500
Received: from cvs.savannah.gnu.org ([199.232.41.69])
	by sv.gnu.org with esmtp (Exim 4.63)
	(envelope-from <INVALID.NOREPLY@gnu.org>) id 1LRY86-0003HA-Hm
	for qemu-devel@nongnu.org; Mon, 26 Jan 2009 20:32:22 +0000
Received: from aliguori by cvs.savannah.gnu.org with local (Exim 4.63)
	(envelope-from <aliguori@savannah.gnu.org>) id 1LRY86-0003H6-CD
	for qemu-devel@nongnu.org; Mon, 26 Jan 2009 20:32:22 +0000
MIME-Version: 1.0
Errors-To: aliguori
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Anthony Liguori <anthony@codemonkey.ws>
Message-Id: <E1LRY86-0003H6-CD@cvs.savannah.gnu.org>
Date: Mon, 26 Jan 2009 20:32:22 +0000
Subject: [Qemu-devel] [6461] kvm-x86: Remove eflags conversion into emulator
	format (Jan Kiszka)
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Revision: 6461
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6461
Author:   aliguori
Date:     2009-01-26 20:32:22 +0000 (Mon, 26 Jan 2009)

Log Message:
-----------
kvm-x86: Remove eflags conversion into emulator format (Jan Kiszka)

It seems that the conversion of the kernel-delivered eflags state into
qemu's internal split representation was once needed in an older kvm
design (register read-back may have taken place from inside cpu_exec).
Today it is plain wrong and causes incorrect cpu state reporting (gdb,
monitor) and should also corrupt its saving (savevm, migration). Drop
the related lines.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

Modified Paths:
--------------
    trunk/target-i386/kvm.c

Modified: trunk/target-i386/kvm.c
===================================================================
--- trunk/target-i386/kvm.c	2009-01-26 20:32:18 UTC (rev 6460)
+++ trunk/target-i386/kvm.c	2009-01-26 20:32:22 UTC (rev 6461)
@@ -445,10 +445,6 @@
             }
     }
     env->hflags = (env->hflags & HFLAG_COPY_MASK) | hflags;
-    env->cc_src = env->eflags & (CC_O | CC_S | CC_Z | CC_A | CC_P | CC_C);
-    env->df = 1 - (2 * ((env->eflags >> 10) & 1));
-    env->cc_op = CC_OP_EFLAGS;
-    env->eflags &= ~(DF_MASK | CC_O | CC_S | CC_Z | CC_A | CC_P | CC_C);
 
     return 0;
 }