From: malc <av1474@comtv.ru>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [6633] Cosmetics
Date: Sat, 21 Feb 2009 05:48:18 +0000 [thread overview]
Message-ID: <E1Lakio-0006N6-4k@cvs.savannah.gnu.org> (raw)
Revision: 6633
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6633
Author: malc
Date: 2009-02-21 05:48:17 +0000 (Sat, 21 Feb 2009)
Log Message:
-----------
Cosmetics
Avoid repeated creation/initalization/destruction of attr and calls to
getpid
Modified Paths:
--------------
trunk/posix-aio-compat.c
Modified: trunk/posix-aio-compat.c
===================================================================
--- trunk/posix-aio-compat.c 2009-02-21 05:48:15 UTC (rev 6632)
+++ trunk/posix-aio-compat.c 2009-02-21 05:48:17 UTC (rev 6633)
@@ -25,6 +25,7 @@
static pthread_mutex_t lock = PTHREAD_MUTEX_INITIALIZER;
static pthread_cond_t cond = PTHREAD_COND_INITIALIZER;
static pthread_t thread_id;
+static pthread_attr_t attr;
static int max_threads = 64;
static int cur_threads = 0;
static int idle_threads = 0;
@@ -76,8 +77,11 @@
static void *aio_thread(void *unused)
{
+ pid_t pid;
sigset_t set;
+ pid = getpid();
+
/* block all signals */
if (sigfillset(&set)) die("sigfillset");
if (sigprocmask(SIG_BLOCK, &set, NULL)) die("sigprocmask");
@@ -142,7 +146,7 @@
idle_threads++;
mutex_unlock(&lock);
- if (kill(getpid(), aiocb->ev_signo)) die("kill failed");
+ if (kill(pid, aiocb->ev_signo)) die("kill failed");
}
idle_threads--;
@@ -154,23 +158,21 @@
static void spawn_thread(void)
{
- int ret;
- pthread_attr_t attr;
-
cur_threads++;
idle_threads++;
-
- ret = pthread_attr_init(&attr);
- if (ret) die2 (ret, "pthread_attr_init");
- ret = pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_DETACHED);
- if (ret) die2 (ret, "pthread_attr_setdetachstate");
thread_create(&thread_id, &attr, aio_thread, NULL);
- ret = pthread_attr_destroy(&attr);
- if (ret) die2 (ret, "pthread_attr_destroy");
}
int qemu_paio_init(struct qemu_paioinit *aioinit)
{
+ int ret;
+
+ ret = pthread_attr_init(&attr);
+ if (ret) die2(ret, "pthread_attr_init");
+
+ ret = pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_DETACHED);
+ if (ret) die2(ret, "pthread_attr_setdetachstate");
+
TAILQ_INIT(&request_list);
return 0;
reply other threads:[~2009-02-21 5:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1Lakio-0006N6-4k@cvs.savannah.gnu.org \
--to=av1474@comtv.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).