From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ld8mV-000885-Uq for qemu-devel@nongnu.org; Fri, 27 Feb 2009 14:54:00 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ld8mV-00087X-9H for qemu-devel@nongnu.org; Fri, 27 Feb 2009 14:53:59 -0500 Received: from [199.232.76.173] (port=40339 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ld8mV-00087F-4C for qemu-devel@nongnu.org; Fri, 27 Feb 2009 14:53:59 -0500 Received: from savannah.gnu.org ([199.232.41.3]:37355 helo=sv.gnu.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Ld8mU-0005gu-Tp for qemu-devel@nongnu.org; Fri, 27 Feb 2009 14:53:59 -0500 Received: from cvs.savannah.gnu.org ([199.232.41.69]) by sv.gnu.org with esmtp (Exim 4.63) (envelope-from ) id 1Ld8mU-0007VS-AK for qemu-devel@nongnu.org; Fri, 27 Feb 2009 19:53:58 +0000 Received: from aliguori by cvs.savannah.gnu.org with local (Exim 4.63) (envelope-from ) id 1Ld8mU-0007VO-3P for qemu-devel@nongnu.org; Fri, 27 Feb 2009 19:53:58 +0000 MIME-Version: 1.0 Errors-To: aliguori Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Anthony Liguori Message-Id: Date: Fri, 27 Feb 2009 19:53:58 +0000 Subject: [Qemu-devel] [6646] Missing cirrus_invalidate_region() in cirrus_do_copy() (Brian Kress) Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Revision: 6646 http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6646 Author: aliguori Date: 2009-02-27 19:53:57 +0000 (Fri, 27 Feb 2009) Log Message: ----------- Missing cirrus_invalidate_region() in cirrus_do_copy() (Brian Kress) After doing a video to video copy, cirrus_do_copy() in cirrus_vga.c does a conditional call to cirrus_invalidate_region() with an "if (!notify)" test. However at this point the blt has already been done so it seems like this call should be made unconditionally. The patch below fixes some display update problems when dragging windows under both X (fedora 10 guest) and a Windows XP guest. Signed-off-by: Brian Kress Signed-off-by: Anthony Liguori Modified Paths: -------------- trunk/hw/cirrus_vga.c Modified: trunk/hw/cirrus_vga.c =================================================================== --- trunk/hw/cirrus_vga.c 2009-02-26 16:40:31 UTC (rev 6645) +++ trunk/hw/cirrus_vga.c 2009-02-27 19:53:57 UTC (rev 6646) @@ -781,10 +781,9 @@ /* we don't have to notify the display that this portion has changed since qemu_console_copy implies this */ - if (!notify) - cirrus_invalidate_region(s, s->cirrus_blt_dstaddr, - s->cirrus_blt_dstpitch, s->cirrus_blt_width, - s->cirrus_blt_height); + cirrus_invalidate_region(s, s->cirrus_blt_dstaddr, + s->cirrus_blt_dstpitch, s->cirrus_blt_width, + s->cirrus_blt_height); } static int cirrus_bitblt_videotovideo_copy(CirrusVGAState * s)