[Qemu-devel] [6655] Change default werror semantics from "report" to "enospc"

[Qemu-devel] [6655] Change default werror semantics from "report" to "enospc"

[Anthony Liguori]

Revision: 6655
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6655
Author:   aliguori
Date:     2009-02-28 16:51:01 +0000 (Sat, 28 Feb 2009)
Log Message:
-----------
Change default werror semantics from "report" to "enospc"

Practically speaking, "report" causes a lot of issues when encountering a host
ENOSPC error.  Switch to "enospc" as the default werror semantics.  All host
errors other than ENOSPC will be reported to the guest.  ENOSPC will cause the
VM to stop.  Asynchronous notifications are needed to inform management tools
that some action should be taken but stopping the VM is at least better than
undefined behavior in the guest.

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

Modified Paths:
--------------
    trunk/vl.c

Modified: trunk/vl.c
===================================================================
--- trunk/vl.c	2009-02-28 08:25:29 UTC (rev 6654)
+++ trunk/vl.c	2009-02-28 16:51:01 UTC (rev 6655)
@@ -2243,7 +2243,7 @@
         if (drives_table[index].bdrv == bdrv)
             return drives_table[index].onerror;
 
-    return BLOCK_ERR_REPORT;
+    return BLOCK_ERR_STOP_ENOSPC;
 }
 
 static void bdrv_format_print(void *opaque, const char *name)
@@ -2479,7 +2479,7 @@
     if (!get_param_value(serial, sizeof(serial), "serial", str))
 	    memset(serial, 0,  sizeof(serial));
 
-    onerror = BLOCK_ERR_REPORT;
+    onerror = BLOCK_ERR_STOP_ENOSPC;
     if (get_param_value(buf, sizeof(serial), "werror", str)) {
         if (type != IF_IDE && type != IF_SCSI && type != IF_VIRTIO) {
             fprintf(stderr, "werror is no supported by this format\n");