From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LdSP3-00019M-4H
	for qemu-devel@nongnu.org; Sat, 28 Feb 2009 11:51:05 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LdSP1-00018p-Lu
	for qemu-devel@nongnu.org; Sat, 28 Feb 2009 11:51:04 -0500
Received: from [199.232.76.173] (port=53793 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LdSP1-00018m-Hc
	for qemu-devel@nongnu.org; Sat, 28 Feb 2009 11:51:03 -0500
Received: from savannah.gnu.org ([199.232.41.3]:49781 helo=sv.gnu.org)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <INVALID.NOREPLY@gnu.org>)
	id 1LdSP1-0005ne-5V
	for qemu-devel@nongnu.org; Sat, 28 Feb 2009 11:51:03 -0500
Received: from cvs.savannah.gnu.org ([199.232.41.69])
	by sv.gnu.org with esmtp (Exim 4.63)
	(envelope-from <INVALID.NOREPLY@gnu.org>) id 1LdSP0-0008B0-Gz
	for qemu-devel@nongnu.org; Sat, 28 Feb 2009 16:51:02 +0000
Received: from aliguori by cvs.savannah.gnu.org with local (Exim 4.69)
	(envelope-from <aliguori@savannah.gnu.org>) id 1LdSP0-0008Aw-7I
	for qemu-devel@nongnu.org; Sat, 28 Feb 2009 16:51:02 +0000
MIME-Version: 1.0
Errors-To: aliguori
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Anthony Liguori <anthony@codemonkey.ws>
Message-Id: <E1LdSP0-0008Aw-7I@cvs.savannah.gnu.org>
Date: Sat, 28 Feb 2009 16:51:02 +0000
Subject: [Qemu-devel] [6655] Change default werror semantics from "report"
	to "enospc"
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Revision: 6655
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6655
Author:   aliguori
Date:     2009-02-28 16:51:01 +0000 (Sat, 28 Feb 2009)
Log Message:
-----------
Change default werror semantics from "report" to "enospc"

Practically speaking, "report" causes a lot of issues when encountering a host
ENOSPC error.  Switch to "enospc" as the default werror semantics.  All host
errors other than ENOSPC will be reported to the guest.  ENOSPC will cause the
VM to stop.  Asynchronous notifications are needed to inform management tools
that some action should be taken but stopping the VM is at least better than
undefined behavior in the guest.

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

Modified Paths:
--------------
    trunk/vl.c

Modified: trunk/vl.c
===================================================================
--- trunk/vl.c	2009-02-28 08:25:29 UTC (rev 6654)
+++ trunk/vl.c	2009-02-28 16:51:01 UTC (rev 6655)
@@ -2243,7 +2243,7 @@
         if (drives_table[index].bdrv == bdrv)
             return drives_table[index].onerror;
 
-    return BLOCK_ERR_REPORT;
+    return BLOCK_ERR_STOP_ENOSPC;
 }
 
 static void bdrv_format_print(void *opaque, const char *name)
@@ -2479,7 +2479,7 @@
     if (!get_param_value(serial, sizeof(serial), "serial", str))
 	    memset(serial, 0,  sizeof(serial));
 
-    onerror = BLOCK_ERR_REPORT;
+    onerror = BLOCK_ERR_STOP_ENOSPC;
     if (get_param_value(buf, sizeof(serial), "werror", str)) {
         if (type != IF_IDE && type != IF_SCSI && type != IF_VIRTIO) {
             fprintf(stderr, "werror is no supported by this format\n");