From: Blue Swirl <blauwirbel@gmail.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [6741] Sparse fixes: dubious mixing of bitwise and logical operations
Date: Sat, 07 Mar 2009 16:03:06 +0000 [thread overview]
Message-ID: <E1LfyzS-0000Eh-6s@cvs.savannah.gnu.org> (raw)
Revision: 6741
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6741
Author: blueswir1
Date: 2009-03-07 16:03:05 +0000 (Sat, 07 Mar 2009)
Log Message:
-----------
Sparse fixes: dubious mixing of bitwise and logical operations
Modified Paths:
--------------
trunk/fpu/softfloat-specialize.h
trunk/hw/cirrus_vga.c
Modified: trunk/fpu/softfloat-specialize.h
===================================================================
--- trunk/fpu/softfloat-specialize.h 2009-03-07 15:59:09 UTC (rev 6740)
+++ trunk/fpu/softfloat-specialize.h 2009-03-07 16:03:05 UTC (rev 6741)
@@ -166,7 +166,7 @@
res = bIsNaN ? bv : av;
}
else if ( aIsNaN ) {
- if ( bIsSignalingNaN | ! bIsNaN )
+ if ( bIsSignalingNaN || ! bIsNaN )
res = av;
else {
returnLargerSignificand:
@@ -301,7 +301,7 @@
res = bIsNaN ? bv : av;
}
else if ( aIsNaN ) {
- if ( bIsSignalingNaN | ! bIsNaN )
+ if ( bIsSignalingNaN || ! bIsNaN )
res = av;
else {
returnLargerSignificand:
@@ -441,7 +441,7 @@
return bIsNaN ? b : a;
}
else if ( aIsNaN ) {
- if ( bIsSignalingNaN | ! bIsNaN ) return a;
+ if ( bIsSignalingNaN || ! bIsNaN ) return a;
returnLargerSignificand:
if ( a.low < b.low ) return b;
if ( b.low < a.low ) return a;
@@ -567,7 +567,7 @@
return bIsNaN ? b : a;
}
else if ( aIsNaN ) {
- if ( bIsSignalingNaN | ! bIsNaN ) return a;
+ if ( bIsSignalingNaN || ! bIsNaN ) return a;
returnLargerSignificand:
if ( lt128( a.high<<1, a.low, b.high<<1, b.low ) ) return b;
if ( lt128( b.high<<1, b.low, a.high<<1, a.low ) ) return a;
Modified: trunk/hw/cirrus_vga.c
===================================================================
--- trunk/hw/cirrus_vga.c 2009-03-07 15:59:09 UTC (rev 6740)
+++ trunk/hw/cirrus_vga.c 2009-03-07 16:03:05 UTC (rev 6741)
@@ -2246,7 +2246,7 @@
CirrusVGAState *s = (CirrusVGAState *)s1;
int size;
- if (!s->sr[0x12] & CIRRUS_CURSOR_SHOW) {
+ if (!(s->sr[0x12] & CIRRUS_CURSOR_SHOW)) {
size = 0;
} else {
if (s->sr[0x12] & CIRRUS_CURSOR_LARGE)
reply other threads:[~2009-03-07 16:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1LfyzS-0000Eh-6s@cvs.savannah.gnu.org \
--to=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).