qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [6846] make qemu_announce_self handle non contiguous net tables ( Marcelo Tosatti)
Date: Fri, 13 Mar 2009 16:18:57 +0000	[thread overview]
Message-ID: <E1LiA65-0006B6-PI@cvs.savannah.gnu.org> (raw)

Revision: 6846
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6846
Author:   aliguori
Date:     2009-03-13 16:18:57 +0000 (Fri, 13 Mar 2009)
Log Message:
-----------
make qemu_announce_self handle non contiguous net tables (Marcelo Tosatti)


With hotplug nd_table might contain holes.

Noticed by Eduardo Habkost.

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

Modified Paths:
--------------
    branches/stable_0_10_0/savevm.c

Modified: branches/stable_0_10_0/savevm.c
===================================================================
--- branches/stable_0_10_0/savevm.c	2009-03-13 15:04:02 UTC (rev 6845)
+++ branches/stable_0_10_0/savevm.c	2009-03-13 16:18:57 UTC (rev 6846)
@@ -118,7 +118,9 @@
     VLANClientState *vc;
     uint8_t buf[256];
 
-    for (i = 0; i < nb_nics; i++) {
+    for (i = 0; i < MAX_NICS; i++) {
+        if (!nd_table[i].used)
+            continue;
         len = announce_self_create(buf, nd_table[i].macaddr);
         vlan = nd_table[i].vlan;
         for(vc = vlan->first_client; vc != NULL; vc = vc->next) {

                 reply	other threads:[~2009-03-13 16:19 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1LiA65-0006B6-PI@cvs.savannah.gnu.org \
    --to=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).