From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LiBpa-0003Ep-8e for qemu-devel@nongnu.org; Fri, 13 Mar 2009 14:10:02 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LiBpY-0003EX-P3 for qemu-devel@nongnu.org; Fri, 13 Mar 2009 14:10:01 -0400 Received: from [199.232.76.173] (port=57145 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LiBpY-0003EU-Lo for qemu-devel@nongnu.org; Fri, 13 Mar 2009 14:10:00 -0400 Received: from savannah.gnu.org ([199.232.41.3]:36988 helo=sv.gnu.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LiBpY-0001pG-CD for qemu-devel@nongnu.org; Fri, 13 Mar 2009 14:10:00 -0400 Received: from cvs.savannah.gnu.org ([199.232.41.69]) by sv.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1LiBpX-0007bG-V0 for qemu-devel@nongnu.org; Fri, 13 Mar 2009 18:10:00 +0000 Received: from aliguori by cvs.savannah.gnu.org with local (Exim 4.69) (envelope-from ) id 1LiBpX-0007bC-M4 for qemu-devel@nongnu.org; Fri, 13 Mar 2009 18:09:59 +0000 MIME-Version: 1.0 Errors-To: aliguori Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Anthony Liguori Message-Id: Date: Fri, 13 Mar 2009 18:09:59 +0000 Subject: [Qemu-devel] [6851] stop dirty logging while updating cirrus bank memory (Glauber Costa) Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Revision: 6851 http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6851 Author: aliguori Date: 2009-03-13 18:09:59 +0000 (Fri, 13 Mar 2009) Log Message: ----------- stop dirty logging while updating cirrus bank memory (Glauber Costa) Otherwise, slot tracking gets confused. This fixes a screen corruption bug with Ubuntu guest installation. Signed-off-by: Glauber Costa Signed-off-by: Avi Kivity Signed-off-by: Anthony Liguori Modified Paths: -------------- trunk/hw/cirrus_vga.c Modified: trunk/hw/cirrus_vga.c =================================================================== --- trunk/hw/cirrus_vga.c 2009-03-13 16:27:31 UTC (rev 6850) +++ trunk/hw/cirrus_vga.c 2009-03-13 18:09:59 UTC (rev 6851) @@ -2637,11 +2637,16 @@ s->lfb_vram_mapped = 0; + cpu_register_physical_memory(isa_mem_base + 0xa0000, 0x8000, + (s->vram_offset + s->cirrus_bank_base[0]) | IO_MEM_UNASSIGNED); + cpu_register_physical_memory(isa_mem_base + 0xa8000, 0x8000, + (s->vram_offset + s->cirrus_bank_base[1]) | IO_MEM_UNASSIGNED); if (!(s->cirrus_srcptr != s->cirrus_srcptr_end) && !((s->sr[0x07] & 0x01) == 0) && !((s->gr[0x0B] & 0x14) == 0x14) && !(s->gr[0x0B] & 0x02)) { + vga_dirty_log_stop((VGAState *)s); cpu_register_physical_memory(isa_mem_base + 0xa0000, 0x8000, (s->vram_offset + s->cirrus_bank_base[0]) | IO_MEM_RAM); cpu_register_physical_memory(isa_mem_base + 0xa8000, 0x8000,