From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LiBqq-0004KQ-AN for qemu-devel@nongnu.org; Fri, 13 Mar 2009 14:11:20 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LiBqp-0004K9-82 for qemu-devel@nongnu.org; Fri, 13 Mar 2009 14:11:19 -0400 Received: from [199.232.76.173] (port=57200 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LiBqp-0004K6-36 for qemu-devel@nongnu.org; Fri, 13 Mar 2009 14:11:19 -0400 Received: from savannah.gnu.org ([199.232.41.3]:37028 helo=sv.gnu.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LiBqo-00020R-QH for qemu-devel@nongnu.org; Fri, 13 Mar 2009 14:11:18 -0400 Received: from cvs.savannah.gnu.org ([199.232.41.69]) by sv.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1LiBqo-000815-CL for qemu-devel@nongnu.org; Fri, 13 Mar 2009 18:11:18 +0000 Received: from aliguori by cvs.savannah.gnu.org with local (Exim 4.69) (envelope-from ) id 1LiBqo-000810-4V for qemu-devel@nongnu.org; Fri, 13 Mar 2009 18:11:18 +0000 MIME-Version: 1.0 Errors-To: aliguori Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Anthony Liguori Message-Id: Date: Fri, 13 Mar 2009 18:11:18 +0000 Subject: [Qemu-devel] [6853] stop dirty logging while updating cirrus bank memory (Glauber Costa) Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Revision: 6853 http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6853 Author: aliguori Date: 2009-03-13 18:11:17 +0000 (Fri, 13 Mar 2009) Log Message: ----------- stop dirty logging while updating cirrus bank memory (Glauber Costa) Otherwise, slot tracking gets confused. This fixes a screen corruption bug with Ubuntu guest installation. Signed-off-by: Glauber Costa Signed-off-by: Avi Kivity Signed-off-by: Anthony Liguori Modified Paths: -------------- branches/stable_0_10_0/hw/cirrus_vga.c Modified: branches/stable_0_10_0/hw/cirrus_vga.c =================================================================== --- branches/stable_0_10_0/hw/cirrus_vga.c 2009-03-13 18:10:13 UTC (rev 6852) +++ branches/stable_0_10_0/hw/cirrus_vga.c 2009-03-13 18:11:17 UTC (rev 6853) @@ -2637,11 +2637,16 @@ s->lfb_vram_mapped = 0; + cpu_register_physical_memory(isa_mem_base + 0xa0000, 0x8000, + (s->vram_offset + s->cirrus_bank_base[0]) | IO_MEM_UNASSIGNED); + cpu_register_physical_memory(isa_mem_base + 0xa8000, 0x8000, + (s->vram_offset + s->cirrus_bank_base[1]) | IO_MEM_UNASSIGNED); if (!(s->cirrus_srcptr != s->cirrus_srcptr_end) && !((s->sr[0x07] & 0x01) == 0) && !((s->gr[0x0B] & 0x14) == 0x14) && !(s->gr[0x0B] & 0x02)) { + vga_dirty_log_stop((VGAState *)s); cpu_register_physical_memory(isa_mem_base + 0xa0000, 0x8000, (s->vram_offset + s->cirrus_bank_base[0]) | IO_MEM_RAM); cpu_register_physical_memory(isa_mem_base + 0xa8000, 0x8000,