From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LnjsN-0007iA-6I for qemu-devel@nongnu.org; Sat, 28 Mar 2009 21:31:51 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LnjsM-0007hn-MQ for qemu-devel@nongnu.org; Sat, 28 Mar 2009 21:31:50 -0400 Received: from [199.232.76.173] (port=34369 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LnjsM-0007hf-Ao for qemu-devel@nongnu.org; Sat, 28 Mar 2009 21:31:50 -0400 Received: from savannah.gnu.org ([199.232.41.3]:39016 helo=sv.gnu.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LnjsM-00041O-1N for qemu-devel@nongnu.org; Sat, 28 Mar 2009 21:31:50 -0400 Received: from cvs.savannah.gnu.org ([199.232.41.69]) by sv.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1LnjsK-0000ml-TY for qemu-devel@nongnu.org; Sun, 29 Mar 2009 01:31:49 +0000 Received: from aliguori by cvs.savannah.gnu.org with local (Exim 4.69) (envelope-from ) id 1LnjsK-0000ma-Ko for qemu-devel@nongnu.org; Sun, 29 Mar 2009 01:31:48 +0000 MIME-Version: 1.0 Errors-To: aliguori Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Anthony Liguori Message-Id: Date: Sun, 29 Mar 2009 01:31:48 +0000 Subject: [Qemu-devel] [6942] remove dead code in bdrv_check_request (Christoph Hellwig) Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Revision: 6942 http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6942 Author: aliguori Date: 2009-03-29 01:31:48 +0000 (Sun, 29 Mar 2009) Log Message: ----------- remove dead code in bdrv_check_request (Christoph Hellwig) Remove code dealing with negative sector numbers for byte access in bdrv_check_request as sector numbers can't ever be negative. Previously we supported negative sector counts for byte access, but never sector numbers. Signed-off-by: Christoph Hellwig Signed-off-by: Anthony Liguori Modified Paths: -------------- trunk/block.c Modified: trunk/block.c =================================================================== --- trunk/block.c 2009-03-29 01:28:29 UTC (rev 6941) +++ trunk/block.c 2009-03-29 01:31:48 UTC (rev 6942) @@ -569,15 +569,7 @@ static int bdrv_check_request(BlockDriverState *bs, int64_t sector_num, int nb_sectors) { - int64_t offset; - - /* Deal with byte accesses */ - if (sector_num < 0) - offset = -sector_num; - else - offset = sector_num * 512; - - return bdrv_check_byte_request(bs, offset, nb_sectors * 512); + return bdrv_check_byte_request(bs, sector_num * 512, nb_sectors * 512); } /* return < 0 if error. See bdrv_write() for the return codes */