[Qemu-devel] [6951] misc scsi disk/cdrom fixes/improvements 1/4

[Qemu-devel] [6951] misc scsi disk/cdrom fixes/improvements 1/4

[Blue Swirl]

Revision: 6951
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6951
Author:   blueswir1
Date:     2009-03-29 15:39:59 +0000 (Sun, 29 Mar 2009)
Log Message:
-----------
misc scsi disk/cdrom fixes/improvements 1/4

Use correct sector size for cdrom Read TOC command

Signed-off-by: Juergen Lock <nox@jelal.kn-bremen.de>

Modified Paths:
--------------
    trunk/hw/scsi-disk.c

Modified: trunk/hw/scsi-disk.c
===================================================================
--- trunk/hw/scsi-disk.c	2009-03-29 15:39:08 UTC (rev 6950)
+++ trunk/hw/scsi-disk.c	2009-03-29 15:39:59 UTC (rev 6951)
@@ -790,6 +790,7 @@
             start_track = buf[6];
             bdrv_get_geometry(s->bdrv, &nb_sectors);
             DPRINTF("Read TOC (track %d format %d msf %d)\n", start_track, format, msf >> 1);
+            nb_sectors /= s->cluster_size;
             switch(format) {
             case 0:
                 toclen = cdrom_read_toc(nb_sectors, outbuf, msf, start_track);

Re: [Qemu-devel] [6951] misc scsi disk/cdrom fixes/improvements 1/4

[Avi Kivity]

Blue Swirl wrote:
> Log Message:
> -----------
> misc scsi disk/cdrom fixes/improvements 1/4
>
> Use correct sector size for cdrom Read TOC command
>   

Meta-comment: in git of the log message, the first line is usually a 
summary of the commit; so if we're planning to switch to git, subjects 
like 'fixed content ?/n' are not helpful.

-- 
error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [6951] misc scsi disk/cdrom fixes/improvements 1/4

[Anthony Liguori]

Avi Kivity wrote:
> Blue Swirl wrote:
>> Log Message:
>> -----------
>> misc scsi disk/cdrom fixes/improvements 1/4
>>
>> Use correct sector size for cdrom Read TOC command
>>   
>
> Meta-comment: in git of the log message, the first line is usually a 
> summary of the commit; so if we're planning to switch to git, subjects 
> like 'fixed content ?/n' are not helpful.

Regardless of git or not, it's useful when sending a patch series to 
make the subject descriptive as opposed to a boiler plate 'series N/M'.

A CodingStyle/SubmittingPatches for QEMU would be rather useful.

Regards,

Anthony Liguori