qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: malc <av1474@comtv.ru>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [6967] Temporary workaround for ppc on ppc
Date: Thu, 02 Apr 2009 01:16:40 +0000	[thread overview]
Message-ID: <E1LpBXs-0001bP-FG@cvs.savannah.gnu.org> (raw)

Revision: 6967
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6967
Author:   malc
Date:     2009-04-02 01:16:39 +0000 (Thu, 02 Apr 2009)
Log Message:
-----------
Temporary workaround for ppc on ppc

target-ppc/translate.c puts values of type opcode_t into .opcodes
section, using GCC extension to do so, and hoping that this will make
them appear contiguously and in the source order in the resulting
executable. This assumption is not safe and is known to be violated
with certain versions of GCC, certain flags passed to it and on
certain platforms (gcc 4.3.0, -O and PPC/PPC64 for instance)

The workaround consists of adding -fno-unit-at-a-time to the list of
GCC command line options while building PPC translate.o on a PPC.

Modified Paths:
--------------
    trunk/Makefile.target

Modified: trunk/Makefile.target
===================================================================
--- trunk/Makefile.target	2009-04-01 23:10:46 UTC (rev 6966)
+++ trunk/Makefile.target	2009-04-02 01:16:39 UTC (rev 6967)
@@ -84,6 +84,10 @@
 HELPER_CFLAGS+=-fomit-frame-pointer
 endif
 
+ifeq ($(subst ppc64,ppc,$(ARCH))$(TARGET_BASE_ARCH),ppcppc)
+translate.o: CFLAGS := $(CFLAGS) $(call cc-option, $(CFLAGS), -fno-unit-at-a-time,)
+endif
+
 ifeq ($(ARCH),sparc)
   CFLAGS+=-ffixed-g2 -ffixed-g3
   ifneq ($(CONFIG_SOLARIS),yes)

             reply	other threads:[~2009-04-02  1:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-02  1:16 malc [this message]
2009-04-02 17:18 ` [Qemu-devel] [6967] Temporary workaround for ppc on ppc Blue Swirl
2009-04-02 18:03   ` malc
2009-04-02 18:18     ` Blue Swirl
2009-04-02 21:01       ` malc
2009-06-08 17:23 ` Mark McLoughlin
2009-06-08 18:26   ` malc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1LpBXs-0001bP-FG@cvs.savannah.gnu.org \
    --to=av1474@comtv.ru \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).