qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [6999] stop dirty tracking just at the end of migration (Glauber Costa)
@ 2009-04-05 19:30 Anthony Liguori
  0 siblings, 0 replies; only message in thread
From: Anthony Liguori @ 2009-04-05 19:30 UTC (permalink / raw)
  To: qemu-devel

Revision: 6999
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6999
Author:   aliguori
Date:     2009-04-05 19:30:55 +0000 (Sun, 05 Apr 2009)
Log Message:
-----------
stop dirty tracking just at the end of migration (Glauber Costa)

If there is still work to do, it is not safe to assume we
can end the dirty tracking. Specifically, kvm can update the dirty
tracking log inside ram_save_block(), leaving pages still out of sync
if we go with the current code.

Based on a patch by Yaniv Kamay

Signed-off-by: Glauber Costa <glommer@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

Modified Paths:
--------------
    trunk/vl.c

Modified: trunk/vl.c
===================================================================
--- trunk/vl.c	2009-04-05 19:30:51 UTC (rev 6998)
+++ trunk/vl.c	2009-04-05 19:30:55 UTC (rev 6999)
@@ -3252,10 +3252,10 @@
     /* try transferring iterative blocks of memory */
 
     if (stage == 3) {
-        cpu_physical_memory_set_dirty_tracking(0);
 
         /* flush all remaining blocks regardless of rate limiting */
         while (ram_save_block(f) != 0);
+        cpu_physical_memory_set_dirty_tracking(0);
     }
 
     qemu_put_be64(f, RAM_SAVE_FLAG_EOS);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-04-05 19:30 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-05 19:30 [Qemu-devel] [6999] stop dirty tracking just at the end of migration (Glauber Costa) Anthony Liguori

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).