From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LqY3W-0004RZ-Gx
	for qemu-devel@nongnu.org; Sun, 05 Apr 2009 15:30:58 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LqY3V-0004Qb-Ij
	for qemu-devel@nongnu.org; Sun, 05 Apr 2009 15:30:58 -0400
Received: from [199.232.76.173] (port=46946 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LqY3V-0004QO-BE
	for qemu-devel@nongnu.org; Sun, 05 Apr 2009 15:30:57 -0400
Received: from savannah.gnu.org ([199.232.41.3]:40663 helo=sv.gnu.org)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <anthony@codemonkey.ws>)
	id 1LqY3U-0008RV-Qw
	for qemu-devel@nongnu.org; Sun, 05 Apr 2009 15:30:57 -0400
Received: from cvs.savannah.gnu.org ([199.232.41.69])
	by sv.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1LqY3U-0000o7-AT
	for qemu-devel@nongnu.org; Sun, 05 Apr 2009 19:30:56 +0000
Received: from aliguori by cvs.savannah.gnu.org with local (Exim 4.69)
	(envelope-from <aliguori@savannah.gnu.org>) id 1LqY3T-0000o3-VL
	for qemu-devel@nongnu.org; Sun, 05 Apr 2009 19:30:56 +0000
MIME-Version: 1.0
Errors-To: aliguori
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Anthony Liguori <anthony@codemonkey.ws>
Message-Id: <E1LqY3T-0000o3-VL@cvs.savannah.gnu.org>
Date: Sun, 05 Apr 2009 19:30:56 +0000
Subject: [Qemu-devel] [6999] stop dirty tracking just at the end of
	migration (Glauber Costa)
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Revision: 6999
          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6999
Author:   aliguori
Date:     2009-04-05 19:30:55 +0000 (Sun, 05 Apr 2009)
Log Message:
-----------
stop dirty tracking just at the end of migration (Glauber Costa)

If there is still work to do, it is not safe to assume we
can end the dirty tracking. Specifically, kvm can update the dirty
tracking log inside ram_save_block(), leaving pages still out of sync
if we go with the current code.

Based on a patch by Yaniv Kamay

Signed-off-by: Glauber Costa <glommer@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

Modified Paths:
--------------
    trunk/vl.c

Modified: trunk/vl.c
===================================================================
--- trunk/vl.c	2009-04-05 19:30:51 UTC (rev 6998)
+++ trunk/vl.c	2009-04-05 19:30:55 UTC (rev 6999)
@@ -3252,10 +3252,10 @@
     /* try transferring iterative blocks of memory */
 
     if (stage == 3) {
-        cpu_physical_memory_set_dirty_tracking(0);
 
         /* flush all remaining blocks regardless of rate limiting */
         while (ram_save_block(f) != 0);
+        cpu_physical_memory_set_dirty_tracking(0);
     }
 
     qemu_put_be64(f, RAM_SAVE_FLAG_EOS);