* [Qemu-devel] [7026] Fix crash on resolution change -> screen dump -> vga redraw ( Avi Kivity)
@ 2009-04-07 20:55 Anthony Liguori
0 siblings, 0 replies; only message in thread
From: Anthony Liguori @ 2009-04-07 20:55 UTC (permalink / raw)
To: qemu-devel
Revision: 7026
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=7026
Author: aliguori
Date: 2009-04-07 20:55:58 +0000 (Tue, 07 Apr 2009)
Log Message:
-----------
Fix crash on resolution change -> screen dump -> vga redraw (Avi Kivity)
The vga screen dump function updates last_width and last_height,
but does not change the DisplaySurface that these variables describe.
A consequent vga_draw_graphic() will therefore fail to resize the
surface and crash.
Fix by invalidating the display state after a screen dump, forcing
vga_draw_graphic() to reallocate the DisplaySurface.
Signed-off-by: Avi Kivity <avi@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Modified Paths:
--------------
trunk/hw/vga.c
Modified: trunk/hw/vga.c
===================================================================
--- trunk/hw/vga.c 2009-04-07 20:55:29 UTC (rev 7025)
+++ trunk/hw/vga.c 2009-04-07 20:55:58 UTC (rev 7026)
@@ -2678,4 +2678,5 @@
vga_screen_dump_graphic(s, filename);
else
vga_screen_dump_text(s, filename);
+ vga_invalidate_display(s);
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-04-07 20:56 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-07 20:55 [Qemu-devel] [7026] Fix crash on resolution change -> screen dump -> vga redraw ( Avi Kivity) Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).