From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ls7Xw-00089a-Tx for qemu-devel@nongnu.org; Thu, 09 Apr 2009 23:36:52 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ls7Xv-00089O-CN for qemu-devel@nongnu.org; Thu, 09 Apr 2009 23:36:51 -0400 Received: from [199.232.76.173] (port=41386 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ls7Xv-00089L-7Q for qemu-devel@nongnu.org; Thu, 09 Apr 2009 23:36:51 -0400 Received: from savannah.gnu.org ([199.232.41.3]:45891 helo=sv.gnu.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Ls7Xu-0003iS-PR for qemu-devel@nongnu.org; Thu, 09 Apr 2009 23:36:51 -0400 Received: from cvs.savannah.gnu.org ([199.232.41.69]) by sv.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ls7Xu-0008PI-2m for qemu-devel@nongnu.org; Fri, 10 Apr 2009 03:36:50 +0000 Received: from pbrook by cvs.savannah.gnu.org with local (Exim 4.69) (envelope-from ) id 1Ls7Xt-0008P9-M3 for qemu-devel@nongnu.org; Fri, 10 Apr 2009 03:36:49 +0000 MIME-Version: 1.0 Errors-To: pbrook Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Paul Brook Message-Id: Date: Fri, 10 Apr 2009 03:36:49 +0000 Subject: [Qemu-devel] [7064] More phys_ram_base elimination. Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Revision: 7064 http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=7064 Author: pbrook Date: 2009-04-10 03:36:49 +0000 (Fri, 10 Apr 2009) Log Message: ----------- More phys_ram_base elimination. Signed-off-by: Paul Brook Modified Paths: -------------- trunk/hw/mips_malta.c trunk/hw/mips_r4k.c trunk/hw/ppce500_mpc8544ds.c trunk/hw/pxa2xx_lcd.c Modified: trunk/hw/mips_malta.c =================================================================== --- trunk/hw/mips_malta.c 2009-04-10 02:24:36 UTC (rev 7063) +++ trunk/hw/mips_malta.c 2009-04-10 03:36:49 UTC (rev 7064) @@ -521,33 +521,34 @@ a3 - RAM size in bytes */ -static void write_bootloader (CPUState *env, unsigned long bios_offset, int64_t kernel_entry) +static void write_bootloader (CPUState *env, uint8_t *base, + int64_t kernel_entry) { uint32_t *p; /* Small bootloader */ - p = (uint32_t *) (phys_ram_base + bios_offset); + p = (uint32_t *)base; stl_raw(p++, 0x0bf00160); /* j 0x1fc00580 */ stl_raw(p++, 0x00000000); /* nop */ /* YAMON service vector */ - stl_raw(phys_ram_base + bios_offset + 0x500, 0xbfc00580); /* start: */ - stl_raw(phys_ram_base + bios_offset + 0x504, 0xbfc0083c); /* print_count: */ - stl_raw(phys_ram_base + bios_offset + 0x520, 0xbfc00580); /* start: */ - stl_raw(phys_ram_base + bios_offset + 0x52c, 0xbfc00800); /* flush_cache: */ - stl_raw(phys_ram_base + bios_offset + 0x534, 0xbfc00808); /* print: */ - stl_raw(phys_ram_base + bios_offset + 0x538, 0xbfc00800); /* reg_cpu_isr: */ - stl_raw(phys_ram_base + bios_offset + 0x53c, 0xbfc00800); /* unred_cpu_isr: */ - stl_raw(phys_ram_base + bios_offset + 0x540, 0xbfc00800); /* reg_ic_isr: */ - stl_raw(phys_ram_base + bios_offset + 0x544, 0xbfc00800); /* unred_ic_isr: */ - stl_raw(phys_ram_base + bios_offset + 0x548, 0xbfc00800); /* reg_esr: */ - stl_raw(phys_ram_base + bios_offset + 0x54c, 0xbfc00800); /* unreg_esr: */ - stl_raw(phys_ram_base + bios_offset + 0x550, 0xbfc00800); /* getchar: */ - stl_raw(phys_ram_base + bios_offset + 0x554, 0xbfc00800); /* syscon_read: */ + stl_raw(base + 0x500, 0xbfc00580); /* start: */ + stl_raw(base + 0x504, 0xbfc0083c); /* print_count: */ + stl_raw(base + 0x520, 0xbfc00580); /* start: */ + stl_raw(base + 0x52c, 0xbfc00800); /* flush_cache: */ + stl_raw(base + 0x534, 0xbfc00808); /* print: */ + stl_raw(base + 0x538, 0xbfc00800); /* reg_cpu_isr: */ + stl_raw(base + 0x53c, 0xbfc00800); /* unred_cpu_isr: */ + stl_raw(base + 0x540, 0xbfc00800); /* reg_ic_isr: */ + stl_raw(base + 0x544, 0xbfc00800); /* unred_ic_isr: */ + stl_raw(base + 0x548, 0xbfc00800); /* reg_esr: */ + stl_raw(base + 0x54c, 0xbfc00800); /* unreg_esr: */ + stl_raw(base + 0x550, 0xbfc00800); /* getchar: */ + stl_raw(base + 0x554, 0xbfc00800); /* syscon_read: */ /* Second part of the bootloader */ - p = (uint32_t *) (phys_ram_base + bios_offset + 0x580); + p = (uint32_t *) (base + 0x580); stl_raw(p++, 0x24040002); /* addiu a0, zero, 2 */ stl_raw(p++, 0x3c1d0000 | (((ENVP_ADDR - 64) >> 16) & 0xffff)); /* lui sp, high(ENVP_ADDR) */ stl_raw(p++, 0x37bd0000 | ((ENVP_ADDR - 64) & 0xffff)); /* ori sp, sp, low(ENVP_ADDR) */ @@ -616,7 +617,7 @@ stl_raw(p++, 0x00000000); /* nop */ /* YAMON subroutines */ - p = (uint32_t *) (phys_ram_base + bios_offset + 0x800); + p = (uint32_t *) (base + 0x800); stl_raw(p++, 0x03e00008); /* jr ra */ stl_raw(p++, 0x24020000); /* li v0,0 */ /* 808 YAMON print */ @@ -662,30 +663,29 @@ static void prom_set(int index, const char *string, ...) { + char buf[ENVP_ENTRY_SIZE]; + target_phys_addr_t p; va_list ap; - int32_t *p; int32_t table_addr; - char *s; if (index >= ENVP_NB_ENTRIES) return; - p = (int32_t *) (phys_ram_base + ENVP_ADDR + VIRT_TO_PHYS_ADDEND); - p += index; + p = ENVP_ADDR + VIRT_TO_PHYS_ADDEND + index * 4; if (string == NULL) { - stl_raw(p, 0); + stl_phys(p, 0); return; } - table_addr = ENVP_ADDR + sizeof(int32_t) * ENVP_NB_ENTRIES + index * ENVP_ENTRY_SIZE; - s = (char *) (phys_ram_base + VIRT_TO_PHYS_ADDEND + table_addr); - + table_addr = ENVP_ADDR + sizeof(int32_t) * ENVP_NB_ENTRIES + + index * ENVP_ENTRY_SIZE + VIRT_TO_PHYS_ADDEND; stl_raw(p, table_addr); va_start(ap, string); - vsnprintf (s, ENVP_ENTRY_SIZE, string, ap); + vsnprintf(buf, ENVP_ENTRY_SIZE, string, ap); va_end(ap); + pstrcpy_targphys(table_addr, ENVP_ENTRY_SIZE, buf); } /* Kernel */ @@ -834,7 +834,7 @@ loaderparams.initrd_filename = initrd_filename; kernel_entry = load_kernel(env); env->CP0_Status &= ~((1 << CP0St_BEV) | (1 << CP0St_ERL)); - write_bootloader(env, bios_offset, kernel_entry); + write_bootloader(env, qemu_get_ram_ptr(bios_offset), kernel_entry); } else { index = drive_get_index(IF_PFLASH, 0, fl_idx); if (index != -1) { @@ -868,11 +868,10 @@ a neat trick which allows bi-endian firmware. */ #ifndef TARGET_WORDS_BIGENDIAN { - uint32_t *addr; - for (addr = (uint32_t *)(phys_ram_base + bios_offset); - addr < (uint32_t *)(phys_ram_base + bios_offset + bios_size); - addr++) { - *addr = bswap32(*addr); + uint32_t *addr = qemu_get_ram_ptr(bios_offset);; + uint32_t *end = addr + bios_size; + while (addr < end) { + bswap32s(addr); } } #endif @@ -881,7 +880,7 @@ /* Board ID = 0x420 (Malta Board with CoreLV) XXX: theoretically 0x1e000010 should map to flash and 0x1fc00010 should map to the board ID. */ - stl_raw(phys_ram_base + bios_offset + 0x10, 0x00000420); + stl_phys(0x1fc00010LL, 0x00000420); /* Init internal devices */ cpu_mips_irq_init_cpu(env); Modified: trunk/hw/mips_r4k.c =================================================================== --- trunk/hw/mips_r4k.c 2009-04-10 02:24:36 UTC (rev 7063) +++ trunk/hw/mips_r4k.c 2009-04-10 03:36:49 UTC (rev 7064) @@ -80,6 +80,7 @@ int64_t entry, kernel_low, kernel_high; long kernel_size, initrd_size; ram_addr_t initrd_offset; + int ret; kernel_size = load_elf(loaderparams.kernel_filename, VIRT_TO_PHYS_ADDEND, (uint64_t *)&entry, (uint64_t *)&kernel_low, @@ -120,21 +121,19 @@ /* Store command line. */ if (initrd_size > 0) { - int ret; - ret = sprintf((char *)(phys_ram_base + (16 << 20) - 256), - "rd_start=0x" TARGET_FMT_lx " rd_size=%li ", - PHYS_TO_VIRT((uint32_t)initrd_offset), - initrd_size); - strcpy ((char *)(phys_ram_base + (16 << 20) - 256 + ret), - loaderparams.kernel_cmdline); + char buf[64]; + ret = snprintf(buf, 64, "rd_start=0x" TARGET_FMT_lx " rd_size=%li ", + PHYS_TO_VIRT((uint32_t)initrd_offset), + initrd_size); + cpu_physical_memory_write((16 << 20) - 256, (void *)buf, 64); + } else { + ret = 0; } - else { - strcpy ((char *)(phys_ram_base + (16 << 20) - 256), - loaderparams.kernel_cmdline); - } + pstrcpy_targphys((16 << 20) - 256 + ret, 256, + loaderparams.kernel_cmdline); - *(int32_t *)(phys_ram_base + (16 << 20) - 260) = tswap32 (0x12345678); - *(int32_t *)(phys_ram_base + (16 << 20) - 264) = tswap32 (ram_size); + stl_phys((16 << 20) - 260, 0x12345678); + stl_phys((16 << 20) - 264, ram_size); } static void main_cpu_reset(void *opaque) Modified: trunk/hw/ppce500_mpc8544ds.c =================================================================== --- trunk/hw/ppce500_mpc8544ds.c 2009-04-10 02:24:36 UTC (rev 7063) +++ trunk/hw/ppce500_mpc8544ds.c 2009-04-10 03:36:49 UTC (rev 7064) @@ -182,7 +182,7 @@ ram_size &= ~(RAM_SIZES_ALIGN - 1); /* Register Memory */ - cpu_register_physical_memory(0, ram_size, 0); + cpu_register_physical_memory(0, ram_size, qemu_ram_alloc(ram_size)); /* MPIC */ irqs = qemu_mallocz(sizeof(qemu_irq) * OPENPIC_OUTPUT_NB); @@ -247,7 +247,8 @@ /* Load initrd. */ if (initrd_filename) { - initrd_size = load_image(initrd_filename, phys_ram_base + initrd_base); + initrd_size = load_image_targphys(initrd_filename, initrd_base, + ram_size - initrd_base); if (initrd_size < 0) { fprintf(stderr, "qemu: could not load initial ram disk '%s'\n", Modified: trunk/hw/pxa2xx_lcd.c =================================================================== --- trunk/hw/pxa2xx_lcd.c 2009-04-10 02:24:36 UTC (rev 7063) +++ trunk/hw/pxa2xx_lcd.c 2009-04-10 03:36:49 UTC (rev 7064) @@ -283,12 +283,11 @@ /* Load new Frame Descriptors from DMA */ static void pxa2xx_descriptor_load(struct pxa2xx_lcdc_s *s) { - struct pxa_frame_descriptor_s *desc[PXA_LCDDMA_CHANS]; + struct pxa_frame_descriptor_s desc; target_phys_addr_t descptr; int i; for (i = 0; i < PXA_LCDDMA_CHANS; i ++) { - desc[i] = 0; s->dma_ch[i].source = 0; if (!s->dma_ch[i].up) @@ -303,15 +302,14 @@ descptr = s->dma_ch[i].descriptor; if (!(descptr >= PXA2XX_SDRAM_BASE && descptr + - sizeof(*desc[i]) <= PXA2XX_SDRAM_BASE + phys_ram_size)) + sizeof(desc) <= PXA2XX_SDRAM_BASE + phys_ram_size)) continue; - descptr -= PXA2XX_SDRAM_BASE; - desc[i] = (struct pxa_frame_descriptor_s *) (phys_ram_base + descptr); - s->dma_ch[i].descriptor = desc[i]->fdaddr; - s->dma_ch[i].source = desc[i]->fsaddr; - s->dma_ch[i].id = desc[i]->fidr; - s->dma_ch[i].command = desc[i]->ldcmd; + cpu_physical_memory_read(descptr, (void *)&desc, sizeof(desc)); + s->dma_ch[i].descriptor = tswap32(desc.fdaddr); + s->dma_ch[i].source = tswap32(desc.fsaddr); + s->dma_ch[i].id = tswap32(desc.fidr); + s->dma_ch[i].command = tswap32(desc.ldcmd); } }