From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [7069] Fix crash on resolution change -> screen dump -> vga redraw ( Avi Kivity)
Date: Fri, 10 Apr 2009 18:36:38 +0000 [thread overview]
Message-ID: <E1LsLag-0001Hv-GO@cvs.savannah.gnu.org> (raw)
Revision: 7069
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=7069
Author: aliguori
Date: 2009-04-10 18:36:38 +0000 (Fri, 10 Apr 2009)
Log Message:
-----------
Fix crash on resolution change -> screen dump -> vga redraw (Avi Kivity)
The vga screen dump function updates last_width and last_height,
but does not change the DisplaySurface that these variables describe.
A consequent vga_draw_graphic() will therefore fail to resize the
surface and crash.
Fix by invalidating the display state after a screen dump, forcing
vga_draw_graphic() to reallocate the DisplaySurface.
Signed-off-by: Avi Kivity <avi@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Modified Paths:
--------------
branches/stable_0_10/hw/vga.c
Modified: branches/stable_0_10/hw/vga.c
===================================================================
--- branches/stable_0_10/hw/vga.c 2009-04-10 16:23:59 UTC (rev 7068)
+++ branches/stable_0_10/hw/vga.c 2009-04-10 18:36:38 UTC (rev 7069)
@@ -2678,4 +2678,5 @@
vga_screen_dump_graphic(s, filename);
else
vga_screen_dump_text(s, filename);
+ vga_invalidate_display(s);
}
reply other threads:[~2009-04-10 18:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1LsLag-0001Hv-GO@cvs.savannah.gnu.org \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).