From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LsLaj-0005ME-P5 for qemu-devel@nongnu.org; Fri, 10 Apr 2009 14:36:41 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LsLai-0005LN-3q for qemu-devel@nongnu.org; Fri, 10 Apr 2009 14:36:41 -0400 Received: from [199.232.76.173] (port=35878 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LsLah-0005LE-Uc for qemu-devel@nongnu.org; Fri, 10 Apr 2009 14:36:40 -0400 Received: from savannah.gnu.org ([199.232.41.3]:46816 helo=sv.gnu.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LsLah-0006di-N5 for qemu-devel@nongnu.org; Fri, 10 Apr 2009 14:36:39 -0400 Received: from cvs.savannah.gnu.org ([199.232.41.69]) by sv.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1LsLah-0001I0-0V for qemu-devel@nongnu.org; Fri, 10 Apr 2009 18:36:39 +0000 Received: from aliguori by cvs.savannah.gnu.org with local (Exim 4.69) (envelope-from ) id 1LsLag-0001Hv-GO for qemu-devel@nongnu.org; Fri, 10 Apr 2009 18:36:38 +0000 MIME-Version: 1.0 Errors-To: aliguori Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Anthony Liguori Message-Id: Date: Fri, 10 Apr 2009 18:36:38 +0000 Subject: [Qemu-devel] [7069] Fix crash on resolution change -> screen dump -> vga redraw ( Avi Kivity) Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Revision: 7069 http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=7069 Author: aliguori Date: 2009-04-10 18:36:38 +0000 (Fri, 10 Apr 2009) Log Message: ----------- Fix crash on resolution change -> screen dump -> vga redraw (Avi Kivity) The vga screen dump function updates last_width and last_height, but does not change the DisplaySurface that these variables describe. A consequent vga_draw_graphic() will therefore fail to resize the surface and crash. Fix by invalidating the display state after a screen dump, forcing vga_draw_graphic() to reallocate the DisplaySurface. Signed-off-by: Avi Kivity Signed-off-by: Anthony Liguori Modified Paths: -------------- branches/stable_0_10/hw/vga.c Modified: branches/stable_0_10/hw/vga.c =================================================================== --- branches/stable_0_10/hw/vga.c 2009-04-10 16:23:59 UTC (rev 7068) +++ branches/stable_0_10/hw/vga.c 2009-04-10 18:36:38 UTC (rev 7069) @@ -2678,4 +2678,5 @@ vga_screen_dump_graphic(s, filename); else vga_screen_dump_text(s, filename); + vga_invalidate_display(s); }