From: Aurelien Jarno <aurelien@aurel32.net>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [7075] target-alpha: remove amask helper
Date: Fri, 10 Apr 2009 21:27:48 +0000 [thread overview]
Message-ID: <E1LsOGK-0005zi-Fa@cvs.savannah.gnu.org> (raw)
Revision: 7075
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=7075
Author: aurel32
Date: 2009-04-10 21:27:48 +0000 (Fri, 10 Apr 2009)
Log Message:
-----------
target-alpha: remove amask helper
The direct use of helper_amask in translate.c was bogus (as env is not
assigned). Directly code amask in tcg and remove the helper.
Signed-off-by: Tristan Gingold <gingold@adacore.com>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Modified Paths:
--------------
trunk/target-alpha/helper.h
trunk/target-alpha/op_helper.c
trunk/target-alpha/translate.c
Modified: trunk/target-alpha/helper.h
===================================================================
--- trunk/target-alpha/helper.h 2009-04-10 21:27:31 UTC (rev 7074)
+++ trunk/target-alpha/helper.h 2009-04-10 21:27:48 UTC (rev 7075)
@@ -3,7 +3,6 @@
DEF_HELPER_0(tb_flush, void)
DEF_HELPER_2(excp, void, int, int)
-DEF_HELPER_1(amask, i64, i64)
DEF_HELPER_0(load_pcc, i64)
DEF_HELPER_0(rc, i64)
DEF_HELPER_0(rs, i64)
Modified: trunk/target-alpha/op_helper.c
===================================================================
--- trunk/target-alpha/op_helper.c 2009-04-10 21:27:31 UTC (rev 7074)
+++ trunk/target-alpha/op_helper.c 2009-04-10 21:27:48 UTC (rev 7075)
@@ -37,21 +37,6 @@
cpu_loop_exit();
}
-uint64_t helper_amask (uint64_t arg)
-{
- switch (env->implver) {
- case IMPLVER_2106x:
- /* EV4, EV45, LCA, LCA45 & EV5 */
- break;
- case IMPLVER_21164:
- case IMPLVER_21264:
- case IMPLVER_21364:
- arg &= ~env->amask;
- break;
- }
- return arg;
-}
-
uint64_t helper_load_pcc (void)
{
/* XXX: TODO */
Modified: trunk/target-alpha/translate.c
===================================================================
--- trunk/target-alpha/translate.c 2009-04-10 21:27:31 UTC (rev 7074)
+++ trunk/target-alpha/translate.c 2009-04-10 21:27:48 UTC (rev 7075)
@@ -1160,9 +1160,20 @@
/* AMASK */
if (likely(rc != 31)) {
if (islit)
- tcg_gen_movi_i64(cpu_ir[rc], helper_amask(lit));
+ tcg_gen_movi_i64(cpu_ir[rc], lit);
else
- gen_helper_amask(cpu_ir[rc], cpu_ir[rb]);
+ tcg_gen_mov_i64(cpu_ir[rc], cpu_ir[rb]);
+ switch (ctx->env->implver) {
+ case IMPLVER_2106x:
+ /* EV4, EV45, LCA, LCA45 & EV5 */
+ break;
+ case IMPLVER_21164:
+ case IMPLVER_21264:
+ case IMPLVER_21364:
+ tcg_gen_andi_i64(cpu_ir[rc], cpu_ir[rc],
+ ~(uint64_t)ctx->amask);
+ break;
+ }
}
break;
case 0x64:
reply other threads:[~2009-04-10 21:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1LsOGK-0005zi-Fa@cvs.savannah.gnu.org \
--to=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).