* [Qemu-devel] [7132] target-mips: simplify exception generation
@ 2009-04-17 13:11 Aurelien Jarno
2009-04-17 13:29 ` Stefan Weil
0 siblings, 1 reply; 3+ messages in thread
From: Aurelien Jarno @ 2009-04-17 13:11 UTC (permalink / raw)
To: qemu-devel
Revision: 7132
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=7132
Author: aurel32
Date: 2009-04-17 13:11:42 +0000 (Fri, 17 Apr 2009)
Log Message:
-----------
target-mips: simplify exception generation
There is no need to exit the tb after a call to helper_raise_exception
as it already calls cpu_loop_exit().
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Modified Paths:
--------------
trunk/target-mips/translate.c
Modified: trunk/target-mips/translate.c
===================================================================
--- trunk/target-mips/translate.c 2009-04-16 15:17:02 UTC (rev 7131)
+++ trunk/target-mips/translate.c 2009-04-17 13:11:42 UTC (rev 7132)
@@ -793,8 +793,6 @@
gen_helper_raise_exception_err(texcp, terr);
tcg_temp_free_i32(terr);
tcg_temp_free_i32(texcp);
- gen_helper_interrupt_restart();
- tcg_gen_exit_tb(0);
}
static inline void
@@ -802,8 +800,6 @@
{
save_cpu_state(ctx, 1);
gen_helper_0i(raise_exception, excp);
- gen_helper_interrupt_restart();
- tcg_gen_exit_tb(0);
}
/* Addresses computation */
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [7132] target-mips: simplify exception generation
2009-04-17 13:11 [Qemu-devel] [7132] target-mips: simplify exception generation Aurelien Jarno
@ 2009-04-17 13:29 ` Stefan Weil
2009-04-17 13:34 ` Aurelien Jarno
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Weil @ 2009-04-17 13:29 UTC (permalink / raw)
To: qemu-devel, Aurelien Jarno
Aurelien Jarno schrieb:
> Revision: 7132
> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=7132
> Author: aurel32
> Date: 2009-04-17 13:11:42 +0000 (Fri, 17 Apr 2009)
> Log Message:
> -----------
> target-mips: simplify exception generation
>
> There is no need to exit the tb after a call to helper_raise_exception
> as it already calls cpu_loop_exit().
>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
>
helper_raise_exception_err is also a candidat.
Regards, Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [7132] target-mips: simplify exception generation
2009-04-17 13:29 ` Stefan Weil
@ 2009-04-17 13:34 ` Aurelien Jarno
0 siblings, 0 replies; 3+ messages in thread
From: Aurelien Jarno @ 2009-04-17 13:34 UTC (permalink / raw)
To: Stefan Weil, qemu-devel
Stefan Weil a écrit :
> Aurelien Jarno schrieb:
>> Revision: 7132
>> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=7132
>> Author: aurel32
>> Date: 2009-04-17 13:11:42 +0000 (Fri, 17 Apr 2009)
>> Log Message:
>> -----------
>> target-mips: simplify exception generation
>>
>> There is no need to exit the tb after a call to helper_raise_exception
>> as it already calls cpu_loop_exit().
>>
>> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
>>
>
> helper_raise_exception_err is also a candidat.
>
I did the change on both, even if not explictely said in the changelog.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-04-17 13:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-17 13:11 [Qemu-devel] [7132] target-mips: simplify exception generation Aurelien Jarno
2009-04-17 13:29 ` Stefan Weil
2009-04-17 13:34 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).