From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [7155] Don't fail PCI hotplug if no NIC model is supplied (Mark McLoughlin)
Date: Fri, 17 Apr 2009 18:06:35 +0000 [thread overview]
Message-ID: <E1LusSR-0004HH-00@cvs.savannah.gnu.org> (raw)
Revision: 7155
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=7155
Author: aliguori
Date: 2009-04-17 18:06:34 +0000 (Fri, 17 Apr 2009)
Log Message:
-----------
Don't fail PCI hotplug if no NIC model is supplied (Mark McLoughlin)
It's perfectly fine to not supply a NIC model when adding
a new NIC - we supply the default model to pci_nic_init()
and it uses that if one wasn't explicitly supplied.
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Modified Paths:
--------------
branches/stable_0_10/hw/pci-hotplug.c
Modified: branches/stable_0_10/hw/pci-hotplug.c
===================================================================
--- branches/stable_0_10/hw/pci-hotplug.c 2009-04-17 18:06:31 UTC (rev 7154)
+++ branches/stable_0_10/hw/pci-hotplug.c 2009-04-17 18:06:34 UTC (rev 7155)
@@ -37,10 +37,10 @@
{
int ret;
- ret = net_client_init ("nic", opts);
- if (ret < 0 || !nd_table[ret].model)
+ ret = net_client_init("nic", opts);
+ if (ret < 0)
return NULL;
- return pci_nic_init (pci_bus, &nd_table[ret], -1, "rtl8139");
+ return pci_nic_init(pci_bus, &nd_table[ret], -1, "rtl8139");
}
void drive_hot_add(const char *pci_addr, const char *opts)
reply other threads:[~2009-04-17 18:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1LusSR-0004HH-00@cvs.savannah.gnu.org \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).