[Qemu-devel] [PATCH v4 0/5] ADB improvements

[Qemu-devel] [PATCH v4 0/5] ADB improvements

[Programmingkid]

This patch series makes several improvements to the ADB code. To test this code,
please implement the patches in the order below.

John Arbuckle (5):
  adb-keys.h: initial commit
  adb.c: add support for QKeyCode
  adb.c: correct several key assignments
  adb.c: prevent NO_KEY value from going to guest
  adb.c: add power key support

 hw/input/adb.c              | 235 +++++++++++++++++++++++++++++++++++---------
 include/hw/input/adb-keys.h | 141 ++++++++++++++++++++++++++
 2 files changed, 330 insertions(+), 46 deletions(-)
 create mode 100644 include/hw/input/adb-keys.h

-- 
*v4 changes:
Replaced ADB_KEY_LEFT_COMAND and ADB_KEY_RIGHT_COMAND with ADB_KEY_COMMAND.
Removed debug printf statement.
Removed stray ".
Rearranged code in "correct several key assignments" and
"prevent NO_KEY value from going to guest" patches. 

*v3 changes:
Removed note from adb-keys.h.
Created new patch that adds QKeyCode support, but doesn't change any mappings.
Made patch that does correct key mappings.
Made new patch the prevents NO_KEY value from going to guest.
Add suggested comments to power key code.
Moved else statement.

*v2 changes:
Swapped order of adb-keys.h and "add support for QKeyCode" patches.

2.7.2

Re: [Qemu-devel] [PATCH v4 0/5] ADB improvements

[Peter Maydell]

On 20 May 2016 at 23:38, Programmingkid <programmingkidx@gmail.com> wrote:
> This patch series makes several improvements to the ADB code. To test this code,
> please implement the patches in the order below.
>
> John Arbuckle (5):
>   adb-keys.h: initial commit
>   adb.c: add support for QKeyCode
>   adb.c: correct several key assignments
>   adb.c: prevent NO_KEY value from going to guest
>   adb.c: add power key support
>
>  hw/input/adb.c              | 235 +++++++++++++++++++++++++++++++++++---------
>  include/hw/input/adb-keys.h | 141 ++++++++++++++++++++++++++
>  2 files changed, 330 insertions(+), 46 deletions(-)
>  create mode 100644 include/hw/input/adb-keys.h

Patches 1..5:
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM

Re: [Qemu-devel] [PATCH v4 0/5] ADB improvements

[Programmingkid]

On May 20, 2016, at 6:48 PM, Peter Maydell wrote:

> On 20 May 2016 at 23:38, Programmingkid <programmingkidx@gmail.com> wrote:
>> This patch series makes several improvements to the ADB code. To test this code,
>> please implement the patches in the order below.
>> 
>> John Arbuckle (5):
>>  adb-keys.h: initial commit
>>  adb.c: add support for QKeyCode
>>  adb.c: correct several key assignments
>>  adb.c: prevent NO_KEY value from going to guest
>>  adb.c: add power key support
>> 
>> hw/input/adb.c              | 235 +++++++++++++++++++++++++++++++++++---------
>> include/hw/input/adb-keys.h | 141 ++++++++++++++++++++++++++
>> 2 files changed, 330 insertions(+), 46 deletions(-)
>> create mode 100644 include/hw/input/adb-keys.h
> 
> Patches 1..5:
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> 
> thanks
> -- PMM

Thank you for looking at the patches so quickly. Have
you seen my patches for the USB keyboard yet?

1/3
https://patchwork.ozlabs.org/patch/602035/

2/3
https://patchwork.ozlabs.org/patch/602036/

3/3
https://patchwork.ozlabs.org/patch/602037/

Re: [Qemu-devel] [PATCH v4 0/5] ADB improvements

[Peter Maydell]

On 21 May 2016 at 00:11, Programmingkid <programmingkidx@gmail.com> wrote:
> On May 20, 2016, at 6:48 PM, Peter Maydell wrote:
>
>> On 20 May 2016 at 23:38, Programmingkid <programmingkidx@gmail.com> wrote:
> Thank you for looking at the patches so quickly. Have
> you seen my patches for the USB keyboard yet?
>
> 1/3
> https://patchwork.ozlabs.org/patch/602035/
>
> 2/3
> https://patchwork.ozlabs.org/patch/602036/
>
> 3/3
> https://patchwork.ozlabs.org/patch/602037/

The USB keyboard is not my area, so I am leaving that
to somebody else.

thanks
-- PMM