From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97E66C433DF for ; Sat, 8 Aug 2020 01:02:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 60FFC20866 for ; Sat, 8 Aug 2020 01:02:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YcF4LvLA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60FFC20866 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47736 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k4DFh-0007Af-Gg for qemu-devel@archiver.kernel.org; Fri, 07 Aug 2020 21:02:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46912) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k4DER-0006iY-Jj for qemu-devel@nongnu.org; Fri, 07 Aug 2020 21:01:08 -0400 Received: from mail-ed1-x543.google.com ([2a00:1450:4864:20::543]:39482) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k4DEP-0007ZG-HI for qemu-devel@nongnu.org; Fri, 07 Aug 2020 21:01:07 -0400 Received: by mail-ed1-x543.google.com with SMTP id c10so2472083edk.6 for ; Fri, 07 Aug 2020 18:01:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:message-id:in-reply-to:references:mime-version; bh=GJVdgaa2l3XkKlfMAGObqxZQM3x5pHsXqacaf3ls4G8=; b=YcF4LvLA4GmuU+8KBa6dwE/TybRP1Y/etoF4xtgON5b9IINy5CDAtT4H5qN4oeiwmW nxZpPP2q3bEENc5ExJ1aRHtUyok8RSf9e1GgkucGbbP5U1hfaTqa2OvwfPaz3gOXBidn GrsR6fHcKYhBK/yUcCwgcPFQ2BPA19r5ZkJ/YCc+7km14Tr8faQiEg+zRR4ZV2hVRAfw /pibWuYEfAp1x0f92/JbaX/eDT1oHEDq+kwBbm9r/Vtdba8Mtb5JJodQE4U70q86Gofs Xi7krIjXoxVq9Dy5kKknprjT4goKSuCDJh53hazWvlKx3sWnccRKmm2Qv74jsG4oJ+Ot 878w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:message-id:in-reply-to :references:mime-version; bh=GJVdgaa2l3XkKlfMAGObqxZQM3x5pHsXqacaf3ls4G8=; b=cs9Ovn+5HNU4u1M0w/nQtj4OrQqWw752r340FxAvR+oHQPUz1U6iEVkzWVs6k0JkFV wPCS3b2MIHSGiSTOY4uIJVYRqzldeLGk8GRKpJljPGkKybRKiWRH3d50MapDGYaNhJxw 3J9F9eWzVkQJQdYnFd1HabILrgLOeBZvX0AsCYL/h/6T7Ty45Yoxov5tnL+HbJ7FYXOI md5hMseBmAESrkt79jRmtVlJddet+IWr6DGgzJMequC9FWk8fkBub5KlGtol0nVyk2vf vfb0rBRw6J9MYTiJvQrQa/P86PJTPV+xxyMzWQlXhu7YYc+Q1+cIrDQbXpWqX0Mmp/iC WdgA== X-Gm-Message-State: AOAM530qbELu36xLkwuHDefvwEw0fJapc3WDkd4aEP5skvdAQ2tcXjjB cLIo5FLlLrE+JYhPMSBBNf9vghol/is= X-Google-Smtp-Source: ABdhPJwaBY2dDVAfSwmaYws4XEASnnJDaROjj5uZGgPDep+yyNMJ5Gne79Jn4Sw+lmMEZKcwOmz6QQ== X-Received: by 2002:a05:6402:1758:: with SMTP id v24mr11614286edx.274.1596848462012; Fri, 07 Aug 2020 18:01:02 -0700 (PDT) Received: from [192.168.100.70] ([213.91.86.150]) by smtp.gmail.com with ESMTPSA id ci27sm7030834ejc.23.2020.08.07.18.01.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2020 18:01:01 -0700 (PDT) Date: Sat, 08 Aug 2020 03:00:54 +0200 From: Nikola Pavlica Subject: Re: [PATCH] ui/gtk: Fix regression in gd_refresh_rate_milihz To: qemu-devel Message-Id: In-Reply-To: <3ZSPEQ.MH51LARSPXFN2@gmail.com> References: <3ZSPEQ.MH51LARSPXFN2@gmail.com> X-Mailer: geary/3.36.2 MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=-dt3kw3m/bfnl1GwGYjAJ" Received-SPF: pass client-ip=2a00:1450:4864:20::543; envelope-from=pavlica.nikola@gmail.com; helo=mail-ed1-x543.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --=-dt3kw3m/bfnl1GwGYjAJ Content-Type: text/plain; charset=us-ascii; format=flowed Apologies, false alarm. I found out that my testing methodology was flawed. Close this. On Sat, Aug 8, 2020 at 00:25, Nikola Pavlica wrote: > From: Nikola Pavlica > > > In January (I think), I suggested a fix for the constant refresh rate > issue in QEMU despite VMs being able to render graphics at a > framerate much higher than that. > > Here's the link to the patch in question: > > > However, I've noticed that the fix for older systems that run a older > system of GTK fail to compile with my version of the patch. Which was > fixed here: > , > but improperly. > > The issue lies if the target system (that the package is build on) > has a higher version of GTK, let's say 3.24, it fails the #ifdef > macro and thus does not include the changes that I've made. I've > noticed this issue under the ArchLinux build system, which can be > fixed by just using the included macro for checking GTK versions. > > Also being that this is a regression and not a plain bugfix, is this > mergable into stable? > > Signed-off-by: Nikola Pavlica > > --- a/ui/gtk.c > +++ b/ui/gtk.c > @@ -1968,7 +1968,7 @@ static GtkWidget > *gd_create_menu_machine(GtkDisplayState *s) > */ > static int gd_refresh_rate_millihz(GtkWidget *window) > { > -#ifdef GDK_VERSION_3_22 > +#if GTK_CHECK_VERSION(3, 22, 0) > GdkWindow *win = gtk_widget_get_window(window); > > if (win) { > -- > 2.24.1 --=-dt3kw3m/bfnl1GwGYjAJ Content-Type: text/html; charset=us-ascii Content-Transfer-Encoding: quoted-printable
Apologies, false alarm.

<= div>I found out that my testing methodology was flawed. Close this.

On Sat, Aug 8, 2020 at 00:25, = Nikola Pavlica <pavlica.nikola@gmail.com> wrote:
From: Nikola Pavlica <pavlica.nikola@gmail.= com> In January (I think), I suggested a fix for the constant refresh rate issue= in QEMU despite VMs being able to render graphics at a framerate much high= er than that.

<= /span>
Here's the link to = the patch in question:

However, I've noticed that the fix for= older systems that run a older system of GTK fail to compile with my versi= on of the patch. Which was fixed here: https://lists.nongnu.= org/archive/html/qemu-devel/2020-01/msg03386.html, but improperly.

The issue lies if the target system (that the package = is build on) has a higher version of GTK, let's say 3.24, it fails the #ifd= ef macro and thus does not include the changes that I've made. I've noticed= this issue under the ArchLinux build system, which can be fixed by just us= ing the included macro for checking GTK versions.

Also being that this is a regression and not a plain bugfix, is t= his mergable into stable?
Signed-off-by: Nikola Pavlica <pavlica.nikola@gmail.com> --- a/ui/gtk.c +++ b/ui/gtk.c @@ -1968,7 +1968,7 @@ static GtkWidget *gd_create_menu_machine(GtkDisplaySt= ate *s) */ static int gd_refresh_rate_millihz(GtkWidget *window) { -#ifdef GDK_VERSION_3_22 +#if GTK_CHECK_VERSION(3, 22, 0) GdkWindow *win =3D gtk_widget_get_window(window); =20 if (win) {
--=20
2.24.1
--=-dt3kw3m/bfnl1GwGYjAJ--