From: "Namsun Ch'o" <namnamc@Safe-mail.net>
To: pmoore@redhat.com
Cc: qemu-devel@nongnu.org, eduardo.otubo@profitbricks.com
Subject: Re: [Qemu-devel] [PATCH] Add a few argument filters to the seccomp sandbox
Date: Fri, 11 Sep 2015 18:45:27 -0400 [thread overview]
Message-ID: <N1-XnvpELVCpt@Safe-mail.net> (raw)
> On Thursday, September 10, 2015 03:48:52 PM Daniel P. Berrange wrote:
> > On Wed, Sep 09, 2015 at 09:55:33PM -0400, namnamc@Safe-mail.net wrote:
> > > +
> > > + /* shmget */
> > > + rc = seccomp_rule_add(ctx, SCMP_ACT_ALLOW, SCMP_SYS(shmget), 2,
> > > + SCMP_A0(SCMP_CMP_EQ, IPC_PRIVATE),
> > > + SCMP_A2(SCMP_CMP_EQ, IP_CREAT|0777));
> >
> > I'm not familiar with semantics of these seccomp rules, but is this
> > saying that the second arg must be exactly equal to IP_CREAT|0777 ?
>
> Yes.
>
> > If the app passes IP_CREAT|0600, would that be permitted instead ?
> > The latter is what I see gtk2 source code passing for mode.
>
> It wouldn't match the rule as written above, if it doesn't match any other
> configured rules it would hit the default filter action.
>
> --
> paul moore
> security @ redhat
I'd already replied to that but in a new top-level thread because I had an
updated patch. Did I misunderstand the "contributing a patch" FAQ? Anyway,
I added the IP_CREAT|0600 rule to the v2 patch:
https://lists.nongnu.org/archive/html/qemu-devel/2015-09/msg02953.html
next reply other threads:[~2015-09-11 22:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 22:45 Namsun Ch'o [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-09-10 1:55 [Qemu-devel] [PATCH] Add a few argument filters to the seccomp sandbox namnamc
2015-09-10 14:48 ` Daniel P. Berrange
2015-09-11 18:58 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=N1-XnvpELVCpt@Safe-mail.net \
--to=namnamc@safe-mail.net \
--cc=eduardo.otubo@profitbricks.com \
--cc=pmoore@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).