From: "Namsun Ch'o" <namnamc@Safe-mail.net>
To: armbru@redhat.com
Cc: qemu-devel@nongnu.org, eduardo.otubo@profitbricks.com
Subject: Re: [Qemu-devel] [PATCH] Add syscalls for -runas and -chroot tothe seccomp sandbox
Date: Mon, 5 Oct 2015 18:58:12 -0400 [thread overview]
Message-ID: <N1-kI2elh--YL@Safe-mail.net> (raw)
> Drawback: complexity. If we decide to limit ourselves to the original
> threat model (rogue guest), and enter the sandbox only after setup, we
> can keep things simpler.
We could do both without much complexity. This looks simple enough to me:
rc = seccomp_rule_add(ctx, SCMP_ACT_ALLOW, SCMP_SYS(chroot), 1,
SCMP_A0(SCMP_CMP_EQ, chroot_dir));
if (rc < 0)
goto seccomp_return;
rc = seccomp_rule_add(ctx, SCMP_ACT_ALLOW, SCMP_SYS(chdir), 1,
SCMP_A0(SCMP_CMP_EQ, "/"));
if (rc < 0)
goto seccomp_return;
The only time chroot_dir is ever used is in os-posix.c:139:
if (chroot(chroot_dir) < 0) {
next reply other threads:[~2015-10-05 22:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 22:58 Namsun Ch'o [this message]
2015-10-06 5:36 ` [Qemu-devel] [PATCH] Add syscalls for -runas and -chroot tothe seccomp sandbox Markus Armbruster
-- strict thread matches above, loose matches on Subject: below --
2015-10-04 5:05 Namsun Ch'o
2015-10-05 5:23 ` Markus Armbruster
2015-10-04 4:00 Namsun Ch'o
2015-10-05 5:20 ` Markus Armbruster
2015-10-05 8:22 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=N1-kI2elh--YL@Safe-mail.net \
--to=namnamc@safe-mail.net \
--cc=armbru@redhat.com \
--cc=eduardo.otubo@profitbricks.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).