From: BALATON Zoltan <balaton@eik.bme.hu>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3] console: Cleanup computation of bytes per pixel and add missing cases
Date: Fri, 24 Aug 2012 17:24:32 +0200 (CEST) [thread overview]
Message-ID: <Pine.GSO.4.64.1208241714240.16113@mono> (raw)
In-Reply-To: <20120824112647.GK10867@stefanha-thinkpad.localdomain>
On Fri, 24 Aug 2012, Stefan Hajnoczi wrote:
>> + case 15:
>> + pf.bits_per_pixel = 16; /* Is this correct? */
>
> A trivial patch can't have "Is this correct?" parts :).
>
> I already applied the simple and correct v2 patch. Feel free to follow
> up with additional cleanups but with resolved "Is this correct?" parts.
The v2 contained all my originally intended changes so it's fine with me.
During review it was discovered that this part of code probably has more
problems so I was trying to provide a fix for those in v3, and then
checkpatch.pl complained about formatting too so I included a fix for that
too. I can resend these broken up into too patches but as I wrote in the
comment I have no way to test if these are correct. The above
bits_per_pixel=16 for 15 bpp case was there already I just added a comment
marking it as suspicious but I'm not sure how to resolve that.
Thanks,
BALATON Zoltan
next prev parent reply other threads:[~2012-08-24 15:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-23 0:08 [Qemu-devel] [PATCH v3] console: Cleanup computation of bytes per pixel and add missing cases BALATON Zoltan
2012-08-24 11:26 ` Stefan Hajnoczi
2012-08-24 15:24 ` BALATON Zoltan [this message]
2012-08-24 15:45 ` Peter Maydell
2012-08-24 18:48 ` BALATON Zoltan
2012-08-24 11:36 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.GSO.4.64.1208241714240.16113@mono \
--to=balaton@eik.bme.hu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).