From: BALATON Zoltan <balaton@eik.bme.hu>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, Stefan Hajnoczi <stefanha@gmail.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3] console: Cleanup computation of bytes per pixel and add missing cases
Date: Fri, 24 Aug 2012 20:48:09 +0200 (CEST) [thread overview]
Message-ID: <Pine.GSO.4.64.1208242034380.21955@mono> (raw)
In-Reply-To: <CAFEAcA-qY2UyAAXBoHwGy0fMqmTFu6zwx4E8SRwLE7S+NZm=-w@mail.gmail.com>
On Fri, 24 Aug 2012, Peter Maydell wrote:
> I think all this code needs careful auditing to (a) clearly define
> what "bpp" means and what "depth" means (assuming we need to distinguish;
> IME they are usually supposed to be synonyms!) and (b) make sure that
> everything that accesses one or the other is actually using the
> right one...
Right, and I don't feel like I can do that for parts I don't know at all
so that's what I meant by not being sure about it and chose to add the
comment as a hint for others who know better where these are used. I think
I've mostly fixed it in vmware_vga which was the part I've looked at.
About depth vs. bpp, they are usually synonyms except for the 32 bits case
where colour depth is actually 24 bits so distinguishing the two is
proabably OK. (This was one of the things that the vmware_vga reported
wrongly and the driver was patching it up with issuing a warning about
it.)
Regards,
BALATON Zoltan
next prev parent reply other threads:[~2012-08-24 18:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-23 0:08 [Qemu-devel] [PATCH v3] console: Cleanup computation of bytes per pixel and add missing cases BALATON Zoltan
2012-08-24 11:26 ` Stefan Hajnoczi
2012-08-24 15:24 ` BALATON Zoltan
2012-08-24 15:45 ` Peter Maydell
2012-08-24 18:48 ` BALATON Zoltan [this message]
2012-08-24 11:36 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.GSO.4.64.1208242034380.21955@mono \
--to=balaton@eik.bme.hu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).