From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60035) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4yvT-0007nM-QR for qemu-devel@nongnu.org; Fri, 24 Aug 2012 14:48:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T4yvS-0002wB-PA for qemu-devel@nongnu.org; Fri, 24 Aug 2012 14:48:11 -0400 Date: Fri, 24 Aug 2012 20:48:09 +0200 (CEST) From: BALATON Zoltan In-Reply-To: Message-ID: References: <20120824112647.GK10867@stefanha-thinkpad.localdomain> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Subject: Re: [Qemu-devel] [PATCH v3] console: Cleanup computation of bytes per pixel and add missing cases List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-trivial@nongnu.org, Stefan Hajnoczi , qemu-devel@nongnu.org On Fri, 24 Aug 2012, Peter Maydell wrote: > I think all this code needs careful auditing to (a) clearly define > what "bpp" means and what "depth" means (assuming we need to distinguish; > IME they are usually supposed to be synonyms!) and (b) make sure that > everything that accesses one or the other is actually using the > right one... Right, and I don't feel like I can do that for parts I don't know at all so that's what I meant by not being sure about it and chose to add the comment as a hint for others who know better where these are used. I think I've mostly fixed it in vmware_vga which was the part I've looked at. About depth vs. bpp, they are usually synonyms except for the 32 bits case where colour depth is actually 24 bits so distinguishing the two is proabably OK. (This was one of the things that the vmware_vga reported wrongly and the driver was patching it up with issuing a warning about it.) Regards, BALATON Zoltan