[Qemu-devel] [patch] alpha - add proper fcntl definitions

[Qemu-devel] [patch] alpha - add proper fcntl definitions

[Vince Weaver]

Hello

On Alpha the target to native fcntl definitions were missing.  Because of
this, programs trying to open files with the O_CREAT option were getting
O_APPEND instead, etc.

This was keeping gcc from the spec benchmarks from running, among other
things.

Vince

Index: linux-user/syscall_defs.h
===================================================================
--- linux-user/syscall_defs.h	(revision 5670)
+++ linux-user/syscall_defs.h	(working copy)
@@ -1749,6 +1749,25 @@
 #define TARGET_O_NOFOLLOW	0x20000	/* don't follow links */
 #define TARGET_O_NOATIME	0x40000
 #define TARGET_O_NDELAY	TARGET_O_NONBLOCK
+#elif defined(TARGET_ALPHA)
+#define TARGET_O_ACCMODE	0x0003
+#define TARGET_O_RDONLY	0x0000
+#define TARGET_O_WRONLY	0x0001
+#define TARGET_O_RDWR		0x0002
+#define TARGET_O_APPEND	0x0008
+#define TARGET_O_SYNC		0x4000
+#define TARGET_O_NONBLOCK	0x0004
+#define TARGET_O_CREAT         0x0200	/* not fcntl */
+#define TARGET_O_TRUNC		0x0400	/* not fcntl */
+#define TARGET_O_EXCL		0x0800	/* not fcntl */
+#define TARGET_O_NOCTTY	0x1000	/* not fcntl */
+#define TARGET_FASYNC		0x2000	/* fcntl, for BSD compatibility */
+#define TARGET_O_LARGEFILE	0x0000	/* not necessary, always 64-bit */
+#define TARGET_O_DIRECT	0x80000	/* direct disk access hint */
+#define TARGET_O_DIRECTORY	0x8000	/* must be a directory */
+#define TARGET_O_NOFOLLOW	0x10000	/* don't follow links */
+#define TARGET_O_NOATIME	0x100000
+#define TARGET_O_NDELAY	TARGET_O_NONBLOCK
 #else
 #define TARGET_O_ACCMODE          0003
 #define TARGET_O_RDONLY             00

Re: [Qemu-devel] [patch] alpha - add proper fcntl definitions

[Aurelien Jarno]

On Tue, Nov 11, 2008 at 12:07:45AM -0500, Vince Weaver wrote:
> Hello
> 
> On Alpha the target to native fcntl definitions were missing.  Because of
> this, programs trying to open files with the O_CREAT option were getting
> O_APPEND instead, etc.
> 
> This was keeping gcc from the spec benchmarks from running, among other
> things.

Thanks, applied.

> Vince
> 
> Index: linux-user/syscall_defs.h
> ===================================================================
> --- linux-user/syscall_defs.h	(revision 5670)
> +++ linux-user/syscall_defs.h	(working copy)
> @@ -1749,6 +1749,25 @@
>  #define TARGET_O_NOFOLLOW	0x20000	/* don't follow links */
>  #define TARGET_O_NOATIME	0x40000
>  #define TARGET_O_NDELAY	TARGET_O_NONBLOCK
> +#elif defined(TARGET_ALPHA)
> +#define TARGET_O_ACCMODE	0x0003
> +#define TARGET_O_RDONLY	0x0000
> +#define TARGET_O_WRONLY	0x0001
> +#define TARGET_O_RDWR		0x0002
> +#define TARGET_O_APPEND	0x0008
> +#define TARGET_O_SYNC		0x4000
> +#define TARGET_O_NONBLOCK	0x0004
> +#define TARGET_O_CREAT         0x0200	/* not fcntl */
> +#define TARGET_O_TRUNC		0x0400	/* not fcntl */
> +#define TARGET_O_EXCL		0x0800	/* not fcntl */
> +#define TARGET_O_NOCTTY	0x1000	/* not fcntl */
> +#define TARGET_FASYNC		0x2000	/* fcntl, for BSD compatibility */
> +#define TARGET_O_LARGEFILE	0x0000	/* not necessary, always 64-bit */
> +#define TARGET_O_DIRECT	0x80000	/* direct disk access hint */
> +#define TARGET_O_DIRECTORY	0x8000	/* must be a directory */
> +#define TARGET_O_NOFOLLOW	0x10000	/* don't follow links */
> +#define TARGET_O_NOATIME	0x100000
> +#define TARGET_O_NDELAY	TARGET_O_NONBLOCK
>  #else
>  #define TARGET_O_ACCMODE          0003
>  #define TARGET_O_RDONLY             00
> 
> 
> 
> 

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net