From: malc <malc@pulsesoft.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] PATCH: uint32_t for pointer arithmetic?
Date: Sat, 18 Sep 2004 15:10:27 +0400 (MSD) [thread overview]
Message-ID: <Pine.LNX.4.55.0409181507500.648@home.oyster.ru> (raw)
In-Reply-To: <87d60jhnrd.fsf@Janik.cz>
On Sat, 18 Sep 2004, [iso-8859-2] Pavel Jan?k wrote:
> Hi,
>
> oss.c is IMHO unnecessary retyping pointers to uint32_t and only after that
> to void *. This means that this will issue two warnings on 64bit platforms:
>
> /home/pavel/QEMU/qemu-cvs/oss.c: In function `AUD_run':
> /home/pavel/QEMU/qemu-cvs/oss.c:406: warning: cast from pointer to integer of different size
> /home/pavel/QEMU/qemu-cvs/oss.c:406: warning: cast to pointer from integer of different size
>
> --- oss.c.~1.5.~ 2004-07-08 21:13:39.000000000 +0200
> +++ oss.c 2004-09-18 12:23:57.017793080 +0200
> @@ -403,7 +403,7 @@
>
> left = oss.bufsize - oss.rpos;
> play = MIN (left, bytes);
> - written = write (oss.fd, (void *) ((uint32_t) oss.buf + oss.rpos), play);
> + written = write (oss.fd, (void *) (oss.buf + oss.rpos), play);
>
> if (-1 == written) {
> if (EAGAIN == errno || EINTR == errno) {
oss.c in CVS, is obsolete(from my point of view anyhow), i would apreciate
if you check following though.
http://www.boblycat.org/~malc/code/patches/qemu/7b_aqemu.patch.gz
--
mailto:malc@pulsesoft.com
next prev parent reply other threads:[~2004-09-18 11:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-18 10:31 [Qemu-devel] PATCH: uint32_t for pointer arithmetic? Pavel Janík
2004-09-18 11:10 ` malc [this message]
2004-09-18 14:25 ` Pavel Janík
2004-09-18 15:09 ` malc
2004-09-18 18:03 ` Sylvain Petreolle
2004-09-18 21:37 ` Pavel Janík
2004-09-18 22:01 ` malc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.55.0409181507500.648@home.oyster.ru \
--to=malc@pulsesoft.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).