qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] Fix gcc4 patch
@ 2005-06-02 21:27 Gwenole Beauchesne
  0 siblings, 0 replies; only message in thread
From: Gwenole Beauchesne @ 2005-06-02 21:27 UTC (permalink / raw)
  To: qemu-devel; +Cc: paul

Hi,

I got a "No return instruction found in op_lmsw_T0" when building qemu
with the gcc4 patch + gcc3.3. push imm8 was misdecoded. Also fixed the
imul case at the same time.

Tested with gcc 3.3.4 (hammer-branch), 3.4.3, 4.0.1 (4.0-branch).

2005-06-02  Gwenole Beauchesne  <gbeauchesne@mandriva.com>

	* dyngen.c (trace_i386_insn): Fix push/imul case with 8-bit
	immediate.

--- dyngen.c.orig	2005-06-02 21:41:51.000000000 +0200
+++ dyngen.c	2005-06-02 22:19:59.000000000 +0200
@@ -1672,14 +1672,19 @@
                 is_prefix = 1;
                 break;
             case 8: /* push immediate */
-            case 10: /* pop immediate */
                 immed = op_size;
                 modrm = 0;
                 break;
+            case 10: /* push 8-bit immediate */
+                immed = 1;
+                modrm = 0;
+                break;
             case 9: /* imul immediate */
-            case 11: /* imul immediate */
                 immed = op_size;
                 break;
+            case 11: /* imul 8-bit immediate */
+                immed = 1;
+                break;
             case 12: /* insb */
             case 13: /* insw */
             case 14: /* outsb */

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-06-02 21:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-06-02 21:27 [Qemu-devel] [PATCH] Fix gcc4 patch Gwenole Beauchesne

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).