From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GGG5H-0004VX-7l for qemu-devel@nongnu.org; Thu, 24 Aug 2006 10:21:27 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GGG5E-0004Rk-H7 for qemu-devel@nongnu.org; Thu, 24 Aug 2006 10:21:26 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GGG5E-0004RM-3Q for qemu-devel@nongnu.org; Thu, 24 Aug 2006 10:21:24 -0400 Received: from [212.13.204.53] (helo=sprocket.fensystems.co.uk) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GGGDI-0006aC-5a for qemu-devel@nongnu.org; Thu, 24 Aug 2006 10:29:44 -0400 Received: from dolphin.home (cpc1-cmbg6-0-0-cust561.cmbg.cable.ntl.com [81.101.138.50]) by sprocket.fensystems.co.uk (Postfix) with ESMTP id 097B01B5F7 for ; Thu, 24 Aug 2006 10:20:51 -0400 (EDT) Date: Thu, 24 Aug 2006 15:20:40 +0100 (BST) From: Michael Brown Message-ID: MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="656896-120586962-1156429240=:2090" Subject: [Qemu-devel] Serial port patch Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --656896-120586962-1156429240=:2090 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed I've found what looks like a bug in hw/serial.c; the structure field "divider" is only a uint8_t, but should be a uint16_t. This currently breaks Etherboot, which is somewhat paranoid about the UART and will verify that both bytes of the divider are functional. (Don't ask me why.) The attached patch fixes the problem for Etherboot. Please cc me on any replies, since I am not a list member. Michael --656896-120586962-1156429240=:2090 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=serial.c.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=serial.c.patch SW5kZXg6IGh3L3NlcmlhbC5jDQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpS Q1MgZmlsZTogL3NvdXJjZXMvcWVtdS9xZW11L2h3L3NlcmlhbC5jLHYNCnJl dHJpZXZpbmcgcmV2aXNpb24gMS4xMg0KZGlmZiAtdSAtcjEuMTIgc2VyaWFs LmMNCi0tLSBody9zZXJpYWwuYwkxMiBBcHIgMjAwNiAyMDo0Mjo0MiAtMDAw MAkxLjEyDQorKysgaHcvc2VyaWFsLmMJMjQgQXVnIDIwMDYgMTQ6MTg6MTkg LTAwMDANCkBAIC03MSw3ICs3MSw3IEBADQogI2RlZmluZSBVQVJUX0xTUl9E UgkweDAxCS8qIFJlY2VpdmVyIGRhdGEgcmVhZHkgKi8NCiANCiBzdHJ1Y3Qg U2VyaWFsU3RhdGUgew0KLSAgICB1aW50OF90IGRpdmlkZXI7DQorICAgIHVp bnQxNl90IGRpdmlkZXI7DQogICAgIHVpbnQ4X3QgcmJyOyAvKiByZWNlaXZl IHJlZ2lzdGVyICovDQogICAgIHVpbnQ4X3QgaWVyOw0KICAgICB1aW50OF90 IGlpcjsgLyogcmVhZCBvbmx5ICovDQpAQCAtMzEwLDcgKzMxMCw3IEBADQog ew0KICAgICBTZXJpYWxTdGF0ZSAqcyA9IG9wYXF1ZTsNCiANCi0gICAgcWVt dV9wdXRfOHMoZiwmcy0+ZGl2aWRlcik7DQorICAgIHFlbXVfcHV0XzE2cyhm LCZzLT5kaXZpZGVyKTsNCiAgICAgcWVtdV9wdXRfOHMoZiwmcy0+cmJyKTsN CiAgICAgcWVtdV9wdXRfOHMoZiwmcy0+aWVyKTsNCiAgICAgcWVtdV9wdXRf OHMoZiwmcy0+aWlyKTsNCkBAIC0zMjgsNyArMzI4LDcgQEANCiAgICAgaWYo dmVyc2lvbl9pZCAhPSAxKQ0KICAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQog DQotICAgIHFlbXVfZ2V0XzhzKGYsJnMtPmRpdmlkZXIpOw0KKyAgICBxZW11 X2dldF8xNnMoZiwmcy0+ZGl2aWRlcik7DQogICAgIHFlbXVfZ2V0XzhzKGYs JnMtPnJicik7DQogICAgIHFlbXVfZ2V0XzhzKGYsJnMtPmllcik7DQogICAg IHFlbXVfZ2V0XzhzKGYsJnMtPmlpcik7DQo= --656896-120586962-1156429240=:2090--