From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GGGSq-0005fg-JR for qemu-devel@nongnu.org; Thu, 24 Aug 2006 10:45:48 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GGGSp-0005e9-Gv for qemu-devel@nongnu.org; Thu, 24 Aug 2006 10:45:47 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GGGSp-0005dt-BG for qemu-devel@nongnu.org; Thu, 24 Aug 2006 10:45:47 -0400 Received: from [212.13.204.53] (helo=sprocket.fensystems.co.uk) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GGGat-0001HF-9K for qemu-devel@nongnu.org; Thu, 24 Aug 2006 10:54:07 -0400 Received: from dolphin.home (cpc1-cmbg6-0-0-cust561.cmbg.cable.ntl.com [81.101.138.50]) by sprocket.fensystems.co.uk (Postfix) with ESMTP id CF0831B5F7 for ; Thu, 24 Aug 2006 10:45:25 -0400 (EDT) Date: Thu, 24 Aug 2006 15:45:15 +0100 (BST) From: Michael Brown In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="656896-2106110264-1156430715=:17165" Subject: [Qemu-devel] Re: Serial port patch Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --656896-2106110264-1156430715=:17165 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed On Thu, 24 Aug 2006, Michael Brown wrote: > I've found what looks like a bug in hw/serial.c; the structure field > "divider" is only a uint8_t, but should be a uint16_t. This currently > breaks Etherboot, which is somewhat paranoid about the UART and will > verify that both bytes of the divider are functional. (Don't ask me > why.) > > The attached patch fixes the problem for Etherboot. > > Please cc me on any replies, since I am not a list member. Sorry; sent the wrong version of the patch by mistake. This should be the right one! Michael --656896-2106110264-1156430715=:17165 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=serial.c.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=serial.c.patch SW5kZXg6IGh3L3NlcmlhbC5jDQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpS Q1MgZmlsZTogL3NvdXJjZXMvcWVtdS9xZW11L2h3L3NlcmlhbC5jLHYNCnJl dHJpZXZpbmcgcmV2aXNpb24gMS4xMg0KZGlmZiAtdSAtcjEuMTIgc2VyaWFs LmMNCi0tLSBody9zZXJpYWwuYwkxMiBBcHIgMjAwNiAyMDo0Mjo0MiAtMDAw MAkxLjEyDQorKysgaHcvc2VyaWFsLmMJMjQgQXVnIDIwMDYgMTQ6NDQ6NDMg LTAwMDANCkBAIC03MSw3ICs3MSw3IEBADQogI2RlZmluZSBVQVJUX0xTUl9E UgkweDAxCS8qIFJlY2VpdmVyIGRhdGEgcmVhZHkgKi8NCiANCiBzdHJ1Y3Qg U2VyaWFsU3RhdGUgew0KLSAgICB1aW50OF90IGRpdmlkZXI7DQorICAgIHVp bnQxNl90IGRpdmlkZXI7DQogICAgIHVpbnQ4X3QgcmJyOyAvKiByZWNlaXZl IHJlZ2lzdGVyICovDQogICAgIHVpbnQ4X3QgaWVyOw0KICAgICB1aW50OF90 IGlpcjsgLyogcmVhZCBvbmx5ICovDQpAQCAtMzEwLDcgKzMxMCw3IEBADQog ew0KICAgICBTZXJpYWxTdGF0ZSAqcyA9IG9wYXF1ZTsNCiANCi0gICAgcWVt dV9wdXRfOHMoZiwmcy0+ZGl2aWRlcik7DQorICAgIHFlbXVfcHV0X2JlMTZz KGYsJnMtPmRpdmlkZXIpOw0KICAgICBxZW11X3B1dF84cyhmLCZzLT5yYnIp Ow0KICAgICBxZW11X3B1dF84cyhmLCZzLT5pZXIpOw0KICAgICBxZW11X3B1 dF84cyhmLCZzLT5paXIpOw0KQEAgLTMyOCw3ICszMjgsNyBAQA0KICAgICBp Zih2ZXJzaW9uX2lkICE9IDEpDQogICAgICAgICByZXR1cm4gLUVJTlZBTDsN CiANCi0gICAgcWVtdV9nZXRfOHMoZiwmcy0+ZGl2aWRlcik7DQorICAgIHFl bXVfZ2V0X2JlMTZzKGYsJnMtPmRpdmlkZXIpOw0KICAgICBxZW11X2dldF84 cyhmLCZzLT5yYnIpOw0KICAgICBxZW11X2dldF84cyhmLCZzLT5pZXIpOw0K ICAgICBxZW11X2dldF84cyhmLCZzLT5paXIpOw0K --656896-2106110264-1156430715=:17165--