From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1FT1iV-0003Iu-Oh
	for qemu-devel@nongnu.org; Mon, 10 Apr 2006 15:06:27 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1FT1iU-0003Ib-4w
	for qemu-devel@nongnu.org; Mon, 10 Apr 2006 15:06:27 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1FT1iT-0003IY-W6
	for qemu-devel@nongnu.org; Mon, 10 Apr 2006 15:06:26 -0400
Received: from [217.10.32.19] (helo=comtv.ru)
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1FT1nB-00074g-9I
	for qemu-devel@nongnu.org; Mon, 10 Apr 2006 15:11:17 -0400
Received: from av1474.oops ([10.0.66.9] verified)
	by comtv.ru (CommuniGate Pro SMTP 4.1.8)
	with ESMTP id 146381073 for qemu-devel@nongnu.org;
	Mon, 10 Apr 2006 23:06:22 +0400
Date: Mon, 10 Apr 2006 23:08:32 +0400 (MSD)
From: malc <malc@pulsesoft.com>
Subject: Re: [Qemu-devel] Updated BGR vs. RGB vga patch...
In-Reply-To: <443AA2DE.3060908@win4lin.com>
Message-ID: <Pine.LNX.4.64.0604102304420.1905@home.oyster.ru>
References: <443A86FC.9010302@win4lin.com>
	<200604101749.00725.paul@codesourcery.com>
	<443A8D0C.4030807@win4lin.com>
	<200604101759.34399.paul@codesourcery.com>
	<443AA2DE.3060908@win4lin.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Mon, 10 Apr 2006, Leonardo E. Reiter wrote:

> Anyway, I didn't spend time figuring out how to query SDL for the ordering. 
> You still have to manually pass in -bgr.  The good news is that all the 
> computation is now done at compile-time, with only very few tests done at 
> run-time.  I agree with your assessment of compile-time versus run-time 
> options... I was merely suggesting a compromise to fend off the minor 
> performance hit of using the old patch.  But the method you suggested is much 
> better and that's how it's implemented now.

I maybe going out on a limb here, but isn't rgb/bgr trivially deducible
from: sdl.c:screen->format->[RGBA]shift.

-- 
mailto:malc@pulsesoft.com