From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ft0VH-0007wc-Qi for qemu-devel@nongnu.org; Wed, 21 Jun 2006 07:04:11 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ft0VG-0007vt-M3 for qemu-devel@nongnu.org; Wed, 21 Jun 2006 07:04:11 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ft0VG-0007vq-Hq for qemu-devel@nongnu.org; Wed, 21 Jun 2006 07:04:10 -0400 Received: from [217.10.32.16] (helo=comtv.ru) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Ft0fz-0002T1-IT for qemu-devel@nongnu.org; Wed, 21 Jun 2006 07:15:16 -0400 Received: from av1474.oops ([10.0.66.9] verified) by comtv.ru (CommuniGate Pro SMTP 4.1.8) with ESMTP id 157382927 for qemu-devel@nongnu.org; Wed, 21 Jun 2006 15:04:07 +0400 Date: Wed, 21 Jun 2006 15:04:26 +0400 (MSD) From: malc Subject: Re: [Qemu-devel] cvttps2dq, movdq2q, movq2dq incorrect behaviour In-Reply-To: Message-ID: References: <200606201154.40985.jseward@acm.org> <200606201248.36106.jseward@acm.org> <200606210131.06270.jseward@acm.org> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323328-1493605657-1150887866=:2135" Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-1493605657-1150887866=:2135 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed On Wed, 21 Jun 2006, malc wrote: > On Wed, 21 Jun 2006, Julian Seward wrote: > >> >> Malc, your sse-movq.patch works for me. Thanks. >> >>> soft-float was a red herring, translate.c is at fault here (interpreter >>> does not use it, hence behaved correctly) [..snip..] >>> >>> cvttps2dq is 0x5b(b=0x5b) with repn prefix (b1=2) the above code is >>> optimized a bit more than it should have been, as it loads only 4 bytes >>> into xmm_t0 instead of 16. >> >> Uh, fine, but I don't understand how/what to fix. Can you advise? > > Following will fix the _specific_ case of cvttps2dq, ideally one > should go through all the [0x50..0x5f, 0xc2] with (repnz,repz prefix) > range and check wether the rules imposed by the above snippet apply. [..snip..] > It appears that cvttps2dq is indeed the only exception in the range, combined patch that fixes both movd?q2d?q and cvttps2dq is attached. I don't have any kind of SSE on this machine so would apprecaite if someone would run tests/test-i386 with the patch attached. -- mailto:malc@pulsesoft.com --8323328-1493605657-1150887866=:2135 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=sse-movXq2Yq-cvttps2dq.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=sse-movXq2Yq-cvttps2dq.patch SW5kZXg6IHRhcmdldC1pMzg2L3RyYW5zbGF0ZS5jDQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09DQpSQ1MgZmlsZTogL2N2c3Jvb3QvcWVtdS9xZW11L3Rhcmdl dC1pMzg2L3RyYW5zbGF0ZS5jLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS41 Nw0KZGlmZiAtdSAtdSAtcjEuNTcgdHJhbnNsYXRlLmMNCi0tLSB0YXJnZXQt aTM4Ni90cmFuc2xhdGUuYwkxNCBKdW4gMjAwNiAxNDoyOTozNCAtMDAwMAkx LjU3DQorKysgdGFyZ2V0LWkzODYvdHJhbnNsYXRlLmMJMjEgSnVuIDIwMDYg MTE6MDE6NDcgLTAwMDANCkBAIC0yOTQ3LDE1ICsyOTQ3LDE1IEBADQogICAg ICAgICBjYXNlIDB4MmQ2OiAvKiBtb3ZxMmRxICovDQogICAgICAgICAgICAg Z2VuX29wX2VudGVyX21teCgpOw0KICAgICAgICAgICAgIHJtID0gKG1vZHJt ICYgNykgfCBSRVhfQihzKTsNCi0gICAgICAgICAgICBnZW5fb3BfbW92cShv ZmZzZXRvZihDUFVYODZTdGF0ZSx4bW1fcmVnc1tybV0uWE1NX1EoMCkpLA0K LSAgICAgICAgICAgICAgICAgICAgICAgIG9mZnNldG9mKENQVVg4NlN0YXRl LGZwcmVnc1tyZWcgJiA3XS5tbXgpKTsNCi0gICAgICAgICAgICBnZW5fb3Bf bW92cV9lbnZfMChvZmZzZXRvZihDUFVYODZTdGF0ZSx4bW1fcmVnc1tybV0u WE1NX1EoMSkpKTsNCisgICAgICAgICAgICBnZW5fb3BfbW92cShvZmZzZXRv ZihDUFVYODZTdGF0ZSx4bW1fcmVnc1tyZWcgJiA3XS5YTU1fUSgwKSksDQor ICAgICAgICAgICAgICAgICAgICAgICAgb2Zmc2V0b2YoQ1BVWDg2U3RhdGUs ZnByZWdzW3JtXS5tbXgpKTsNCisgICAgICAgICAgICBnZW5fb3BfbW92cV9l bnZfMChvZmZzZXRvZihDUFVYODZTdGF0ZSx4bW1fcmVnc1tyZWcgJiA3XS5Y TU1fUSgxKSkpOw0KICAgICAgICAgICAgIGJyZWFrOw0KICAgICAgICAgY2Fz ZSAweDNkNjogLyogbW92ZHEycSAqLw0KICAgICAgICAgICAgIGdlbl9vcF9l bnRlcl9tbXgoKTsNCiAgICAgICAgICAgICBybSA9IChtb2RybSAmIDcpOw0K LSAgICAgICAgICAgIGdlbl9vcF9tb3ZxKG9mZnNldG9mKENQVVg4NlN0YXRl LGZwcmVnc1tybV0ubW14KSwNCi0gICAgICAgICAgICAgICAgICAgICAgICBv ZmZzZXRvZihDUFVYODZTdGF0ZSx4bW1fcmVnc1tyZWddLlhNTV9RKDApKSk7 DQorICAgICAgICAgICAgZ2VuX29wX21vdnEob2Zmc2V0b2YoQ1BVWDg2U3Rh dGUsZnByZWdzW3JlZ10ubW14KSwNCisgICAgICAgICAgICAgICAgICAgICAg ICBvZmZzZXRvZihDUFVYODZTdGF0ZSx4bW1fcmVnc1tybV0uWE1NX1EoMCkp KTsNCiAgICAgICAgICAgICBicmVhazsNCiAgICAgICAgIGNhc2UgMHhkNzog LyogcG1vdm1za2IgKi8NCiAgICAgICAgIGNhc2UgMHgxZDc6DQpAQCAtMzAw Niw4ICszMDA2LDkgQEANCiAgICAgICAgICAgICBpZiAobW9kICE9IDMpIHsN CiAgICAgICAgICAgICAgICAgZ2VuX2xlYV9tb2RybShzLCBtb2RybSwgJnJl Z19hZGRyLCAmb2Zmc2V0X2FkZHIpOw0KICAgICAgICAgICAgICAgICBvcDJf b2Zmc2V0ID0gb2Zmc2V0b2YoQ1BVWDg2U3RhdGUseG1tX3QwKTsNCi0gICAg ICAgICAgICAgICAgaWYgKGIxID49IDIgJiYgKChiID49IDB4NTAgJiYgYiA8 PSAweDVmKSB8fA0KLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg YiA9PSAweGMyKSkgew0KKyAgICAgICAgICAgICAgICBpZiAoIShiMSA9PSAy ICYmIGIgPT0gMHg1YikgJiYNCisgICAgICAgICAgICAgICAgICAgIChiMSA+ PSAyICYmICgoYiA+PSAweDUwICYmIGIgPD0gMHg1ZikgfHwNCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGIgPT0gMHhjMikpKSB7DQogICAg ICAgICAgICAgICAgICAgICAvKiBzcGVjaWZpYyBjYXNlIGZvciBTU0Ugc2lu Z2xlIGluc3RydWN0aW9ucyAqLw0KICAgICAgICAgICAgICAgICAgICAgaWYg KGIxID09IDIpIHsNCiAgICAgICAgICAgICAgICAgICAgICAgICAvKiAzMiBi aXQgYWNjZXNzICovDQo= --8323328-1493605657-1150887866=:2135--