From: malc <malc@pulsesoft.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] handle multibyte NOPs
Date: Mon, 21 Aug 2006 02:15:34 +0400 (MSD) [thread overview]
Message-ID: <Pine.LNX.4.64.0608210212150.11941@home.oyster.ru> (raw)
In-Reply-To: <b2fa41d60608201451q9a65c9o10241f3c07132395@mail.gmail.com>
On Mon, 21 Aug 2006, Igor Kovalenko wrote:
> On 8/19/06, Paul Brook <paul@codesourcery.com> wrote:
>>
>> On Saturday 19 August 2006 00:40, Igor Kovalenko wrote:
>> > Hi!
>> >
>> > This patch adds handling of multi-byte NOPs, recent gcc/gas uses them
>> for
>> > x86 code padding.
>> > Patch checked with current opensuse-factory x86 guest installation which
>> is
>> > built with new gcc/gas tools.
>>
>> According to my amd64 documentation all of the opcodes 0f 19 through 0f 1f
>> should be implemented as a NOP. Also, I suspect the "invalid" prefetch ops
>> (0f 18) should also be implemented as nops.
>> The same implementation should be useable to all these opcodes.
>>
>>
> Updated patch, extracted noop modrm processing into separate function and
> used it for 0f 18 case as well. I also removed reg sense from noop
> processing.
Case labels in your `switch (mod)' statement are incorrect. I guess you
wanted 0x to behave like 0b, while it works for 0 and 1, for everything
else it's way of.
--
mailto:malc@pulsesoft.com
next prev parent reply other threads:[~2006-08-20 22:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-18 23:40 [Qemu-devel] [PATCH] handle multibyte NOPs Igor Kovalenko
2006-08-19 0:28 ` Paul Brook
2006-08-20 21:51 ` Igor Kovalenko
2006-08-20 22:15 ` malc [this message]
2006-08-20 22:28 ` Igor Kovalenko
2006-08-20 22:39 ` malc
2006-08-20 22:47 ` Igor Kovalenko
2006-08-20 23:18 ` malc
2006-08-30 19:27 ` Igor Kovalenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0608210212150.11941@home.oyster.ru \
--to=malc@pulsesoft.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).