From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GEwZQ-0002MF-Qx for qemu-devel@nongnu.org; Sun, 20 Aug 2006 19:19:08 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GEwZP-0002Lv-UB for qemu-devel@nongnu.org; Sun, 20 Aug 2006 19:19:08 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GEwZP-0002Ls-Qr for qemu-devel@nongnu.org; Sun, 20 Aug 2006 19:19:07 -0400 Received: from [217.10.32.17] (helo=comtv.ru) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GEwgd-0000XZ-SM for qemu-devel@nongnu.org; Sun, 20 Aug 2006 19:26:37 -0400 Received: from av1474.oops ([10.0.66.9] verified) by comtv.ru (CommuniGate Pro SMTP 4.1.8) with ESMTP id 164851425 for qemu-devel@nongnu.org; Mon, 21 Aug 2006 03:18:53 +0400 Date: Mon, 21 Aug 2006 03:18:59 +0400 (MSD) From: malc Subject: Re: [Qemu-devel] [PATCH] handle multibyte NOPs In-Reply-To: Message-ID: References: <200608190128.12476.paul@codesourcery.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Mon, 21 Aug 2006, Igor Kovalenko wrote: > On 8/21/06, malc wrote: >> >> On Mon, 21 Aug 2006, Igor Kovalenko wrote: >> >> >> >> > Right. Here is the real one with correct case labels. >> >> Sorry, forgot to mention that atop of the hex/bin problem the code also >> suffers from lack of proper 16/64 bit modrm decoding. > > > seems to me that 16 and 64 bit cases does not apply here Well, quick experiment in vm86 environment suggests that i'm right at least for 16bit case. xor ax, ax int 16h db 0xf, 0x19, 5, 0xde, 0xad db 0xf, 0x19, 5, 0xbe, 0xef mov ah, 9 mov dx, erm add dx, 0x100 int 21h xor ax, ax int 16h ret erm db "moo$" nasm -o moo.com moo.asm dosemu moo.com 64bit case should be investigated by someone who possesses 64bit OS. -- mailto:malc@pulsesoft.com