From: malc <malc@pulsesoft.com>
To: Blue Swirl <blueswir1@hotmail.com>
Cc: qemu-devel@nongnu.org
Subject: RE: [Qemu-devel] Re: Audio output for CS4231, patch/RFC
Date: Sun, 24 Sep 2006 14:39:30 +0400 (MSD) [thread overview]
Message-ID: <Pine.LNX.4.64.0609241438480.660@home.oyster.ru> (raw)
In-Reply-To: <BAY104-F3376F477FDD23EE6338455FF270@phx.gbl>
On Sun, 24 Sep 2006, Blue Swirl wrote:
>> After having a cursory look at it only one thing really caught my
>> attention:
>> in the audio callback you set s->audio_free to the provided value, but then
>> in you never use it. If i'm reading everything correctly this would lead to
>> reading N bytes from DMA in write_audio, succeeding in writing only M bytes
>> (where M < N) to the audio subsystem and loosing N-M bytes forever.
>> Basically
>> you should never attempt to do volatile reads of more than audio_free
>> bytes.
>> SB16 operates in similar fashion.
>
> Okay, thanks for the clarification.
>
> By the way, I couldn't find where AUD_open_out is implemented, what did I
> miss?
audio/audio_template.h (since code is mostly the same for in and out)
--
mailto:malc@pulsesoft.com
prev parent reply other threads:[~2006-09-24 10:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-23 16:13 [Qemu-devel] Audio output for CS4231, patch/RFC Blue Swirl
2006-09-23 17:52 ` [Qemu-devel] " Fabrice Bellard
2006-09-23 19:14 ` Blue Swirl
2006-09-24 3:22 ` malc
2006-09-24 6:23 ` Blue Swirl
2006-09-24 10:39 ` malc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0609241438480.660@home.oyster.ru \
--to=malc@pulsesoft.com \
--cc=blueswir1@hotmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).