From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GRRNz-0005EN-Tt for qemu-devel@nongnu.org; Sun, 24 Sep 2006 06:38:59 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GRRNz-0005DM-2J for qemu-devel@nongnu.org; Sun, 24 Sep 2006 06:38:59 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GRRNy-0005DE-UT for qemu-devel@nongnu.org; Sun, 24 Sep 2006 06:38:58 -0400 Received: from [217.10.32.17] (helo=comtv.ru) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GRRS9-00089u-1c for qemu-devel@nongnu.org; Sun, 24 Sep 2006 06:43:17 -0400 Date: Sun, 24 Sep 2006 14:39:30 +0400 (MSD) From: malc Subject: RE: [Qemu-devel] Re: Audio output for CS4231, patch/RFC In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org On Sun, 24 Sep 2006, Blue Swirl wrote: >> After having a cursory look at it only one thing really caught my >> attention: >> in the audio callback you set s->audio_free to the provided value, but then >> in you never use it. If i'm reading everything correctly this would lead to >> reading N bytes from DMA in write_audio, succeeding in writing only M bytes >> (where M < N) to the audio subsystem and loosing N-M bytes forever. >> Basically >> you should never attempt to do volatile reads of more than audio_free >> bytes. >> SB16 operates in similar fashion. > > Okay, thanks for the clarification. > > By the way, I couldn't find where AUD_open_out is implemented, what did I > miss? audio/audio_template.h (since code is mostly the same for in and out) -- mailto:malc@pulsesoft.com