From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HTKHU-0003Xj-Ga for qemu-devel@nongnu.org; Mon, 19 Mar 2007 12:00:20 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HTKHN-0003TH-OM for qemu-devel@nongnu.org; Mon, 19 Mar 2007 12:00:14 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HTKHM-0003T2-Mm for qemu-devel@nongnu.org; Mon, 19 Mar 2007 11:00:12 -0500 Received: from grayson.netsweng.com ([207.235.77.11]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HTKFt-0001r5-CM for qemu-devel@nongnu.org; Mon, 19 Mar 2007 11:58:41 -0400 Received: from amavis by grayson.netsweng.com with scanned-ok (Exim 3.36 #1 (Debian)) id 1HTKFs-0000gZ-00 for ; Mon, 19 Mar 2007 11:58:40 -0400 Received: from grayson.netsweng.com ([127.0.0.1]) by localhost (grayson.netsweng.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id j532lAtQH7pP for ; Mon, 19 Mar 2007 11:58:17 -0400 (EDT) Received: from h211.241.141.67.ip.alltel.net ([67.141.241.211] helo=trantor.stuart.netsweng.com) by grayson.netsweng.com with esmtp (Exim 3.36 #1 (Debian)) id 1HTKFU-0000g5-00 for ; Mon, 19 Mar 2007 11:58:17 -0400 Date: Mon, 19 Mar 2007 11:57:55 -0400 (EDT) From: Stuart Anderson Subject: Re: [Qemu-devel] [PATCH] EABI fcntl on x86_64 In-Reply-To: <200703191538.51607.paul@codesourcery.com> Message-ID: References: <200703191538.51607.paul@codesourcery.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Mon, 19 Mar 2007, Paul Brook wrote: > On Monday 19 March 2007 15:30, Stuart Anderson wrote: >> When running ARM EABI binaries on x86_64, the target_eabi_flock64 >> structure is already padded correct so the padding is not needed. >> This patch adds an #ifdef to only include the _pad member on 32-but >> hosts. > > This is wrong. The struct is packed, so its layout should be independent of > the host. How did you test your change? I have a debian arm chroot setup. dpkg was unhappy, and I used gdb to observe that there seemed to an extra 4 bytes of data in the middle of the structure being passed into the host function. I missed Kirill's patch as it came across before I got back on the list, (and I missedit when I browsed the archive as well). Since I should be able to reproduce this, I'll test w/ his fix as well. Stuart Stuart R. Anderson anderson@netsweng.com Network & Software Engineering http://www.netsweng.com/ 1024D/37A79149: 0791 D3B8 9A4C 2CDC A31F BD03 0A62 E534 37A7 9149