Re: [Qemu-devel] [PATCH] fcntl64 fix

[Stuart Anderson <anderson@netsweng.com>]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 975 bytes --]

On Mon, 19 Mar 2007, Stuart Anderson wrote:

>
> My initial fix was before I started using LTP, and just took care of a
> single case that was holding me up. Now I have run the fcntl tests in
> LTP on ARM (both oABI and EABI) and there are a lot of failures indicating
> that there is a lot more work to be done yet on fcntl().
>
> I'll take a look into it, and probably resubmit a bigger patch later.

One more small fix to repack a structure from taget -> host before using
it clears up most of the fcntl() errors that showed up in LTP. This is
one of those that probably doesn't happen when runngin 32 on 32, but I'm
running 32 on 64.



                                 Stuart

Stuart R. Anderson                               anderson@netsweng.com
Network & Software Engineering                   http://www.netsweng.com/
1024D/37A79149:                                  0791 D3B8 9A4C 2CDC A31F
                                                  BD03 0A62 E534 37A7 9149

[-- Attachment #2: fcntl fix --]
[-- Type: TEXT/PLAIN, Size: 662 bytes --]

--- linux-user/syscall.c.orig	2007-03-20 01:25:39.000000000 -0400
+++ linux-user/syscall.c	2007-03-20 02:32:39.000000000 -0400
@@ -2107,6 +2107,13 @@
 
     switch(cmd) {
     case TARGET_F_GETLK:
+        lock_user_struct(target_fl, arg, 1);
+        fl.l_type = tswap16(target_fl->l_type);
+        fl.l_whence = tswap16(target_fl->l_whence);
+        fl.l_start = tswapl(target_fl->l_start);
+        fl.l_len = tswapl(target_fl->l_len);
+        fl.l_pid = tswapl(target_fl->l_pid);
+        unlock_user_struct(target_fl, arg, 0);
         ret = fcntl(fd, cmd, &fl);
         if (ret == 0) {
             lock_user_struct(target_fl, arg, 0);