From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1HTnQx-0006u6-Pl
	for qemu-devel@nongnu.org; Tue, 20 Mar 2007 19:08:03 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1HTnQx-0006tu-7f
	for qemu-devel@nongnu.org; Tue, 20 Mar 2007 19:08:03 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1HTnQx-0006tr-2r
	for qemu-devel@nongnu.org; Tue, 20 Mar 2007 18:08:03 -0500
Received: from grayson.netsweng.com ([207.235.77.11])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anderson@netsweng.com>) id 1HTnPK-00054G-Jb
	for qemu-devel@nongnu.org; Tue, 20 Mar 2007 19:06:22 -0400
Date: Tue, 20 Mar 2007 19:05:33 -0400 (EDT)
From: Stuart Anderson <anderson@netsweng.com>
Subject: Re: [Qemu-devel] [PATCH] fcntl64 fix
In-Reply-To: <20070320214749.GE2311@networkno.de>
Message-ID: <Pine.LNX.4.64.0703201852120.12505@trantor.stuart.netsweng.com>
References: <20070319171303.GE28895@networkno.de>
	<20070320114315.GA26019@localhost.localdomain>
	<Pine.LNX.4.64.0703200954000.12505@trantor.stuart.netsweng.com>
	<20070320135910.GA18571@localhost.localdomain>
	<Pine.LNX.4.64.0703201252460.12505@trantor.stuart.netsweng.com>
	<20070320171103.GA20530@localhost.localdomain>
	<Pine.LNX.4.64.0703201358190.12505@trantor.stuart.netsweng.com>
	<20070320193442.GA11933@localhost.localdomain>
	<Pine.LNX.4.64.0703201625070.12505@trantor.stuart.netsweng.com>
	<Pine.LNX.4.64.0703201713390.12505@trantor.stuart.netsweng.com>
	<20070320214749.GE2311@networkno.de>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thiemo Seufer <ths@networkno.de>
Cc: qemu-devel@nongnu.org

On Tue, 20 Mar 2007, Thiemo Seufer wrote:

> Still, this part makes no sense to me since it is in a packed struct.
> Can you explain why this works better for you?

It worked better, in that it fixed a problem that let me continue on to
fix other issues. After revisiting fcntl() and coming up with the more
comprehensive patch, this change now seems to have no effect, so I
must conceed that it is not needed, please drop that part of the patch.

Now that the dust has settled, I see where the change is probably a
no-op anyway. A quick little test program indicates that on x86_64,
l_start will have an offset of 8 wether the structure is packed or not,
and wether the __pad member is present or not. The unsigned long long is
always going to be aligned to a 8 byte boundary.

                                 Stuart

Stuart R. Anderson                               anderson@netsweng.com
Network & Software Engineering                   http://www.netsweng.com/
1024D/37A79149:                                  0791 D3B8 9A4C 2CDC A31F
                                                  BD03 0A62 E534 37A7 9149