From: Stuart Anderson <anderson@netsweng.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] fcntl64 fix
Date: Wed, 21 Mar 2007 09:49:51 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0703210930590.12505@trantor.stuart.netsweng.com> (raw)
In-Reply-To: <20070320225957.GB32229@localhost.localdomain>
On Wed, 21 Mar 2007, Kirill A. Shutemov wrote:
> Primarily, I also thought that problem is in padding, because, without the
> patch F_GETLK, on 32-bit target recognises as F_GETLK64 on 64-bit host.
> It's happen because on 64-bit host and 32-bit target F_GETLK == F_GETLK64 ==
> TARGET_F_GETLK. So if you're using qemu-arm on 64-bit host and a target eabi
> program calls fcntl(fd,F_GETLK,...), target_eabi_flock64 will be used by
> mistake. Disabling padding can helps in some trivial cases to pass
> pseudo-correct args to fcntl. I guess this part of patch wrong.
>
> Stuart, am I right?
Yes, this is a good summary of the trap I initially fell into.
Stuart
Stuart R. Anderson anderson@netsweng.com
Network & Software Engineering http://www.netsweng.com/
1024D/37A79149: 0791 D3B8 9A4C 2CDC A31F
BD03 0A62 E534 37A7 9149
next prev parent reply other threads:[~2007-03-21 13:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-09 21:53 [Qemu-devel] [PATCH] fcntl64 fix Kirill A. Shutemov
2007-03-19 17:13 ` Thiemo Seufer
2007-03-19 17:48 ` Stuart Anderson
2007-03-20 6:46 ` Stuart Anderson
2007-03-20 11:43 ` Kirill A. Shutemov
[not found] ` <Pine.LNX.4.64.0703200954000.12505@trantor.stuart.netsweng.com>
2007-03-20 13:59 ` Kirill A. Shutemov
2007-03-20 16:54 ` Stuart Anderson
2007-03-20 17:11 ` Kirill A. Shutemov
2007-03-20 18:03 ` Stuart Anderson
2007-03-20 19:34 ` Kirill A. Shutemov
2007-03-20 20:26 ` Stuart Anderson
2007-03-20 21:32 ` Stuart Anderson
2007-03-20 21:40 ` Paul Brook
2007-03-20 21:47 ` Thiemo Seufer
2007-03-20 22:56 ` Kirill A. Shutemov
2007-03-20 22:59 ` Kirill A. Shutemov
2007-03-21 13:49 ` Stuart Anderson [this message]
2007-03-20 23:05 ` Stuart Anderson
2007-03-20 23:10 ` Kirill A. Shutemov
2007-03-20 23:11 ` Kirill A. Shutemov
2007-03-20 23:43 ` Paul Brook
2007-03-21 13:50 ` Stuart Anderson
2007-03-22 14:23 ` Kirill A. Shutemov
-- strict thread matches above, loose matches on Subject: below --
2007-03-09 21:48 Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0703210930590.12505@trantor.stuart.netsweng.com \
--to=anderson@netsweng.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).